Re: [PATCH] Monitor command to translate guest physical address to host virtual address

[Avi Kivity <avi@redhat.com>]

  On 10/02/2010 10:16 AM, Avi Kivity wrote:
>  On 10/02/2010 12:53 AM, Marcelo Tosatti wrote:
>> On Fri, Oct 01, 2010 at 09:52:25AM +0800, Huang Ying wrote:
>> >  From: Max Asbock<masbock@linux.vnet.ibm.com>
>> >
>> >  Add command p2v to translate guest physical address to host virtual
>> >  address.
>> >
>> >  The p2v command provides one step in a chain of translations from
>> >  guest virtual to guest physical to host virtual to host physical. 
>> Host
>> >  physical is then used to inject a machine check error. As a
>> >  consequence the HWPOISON code on the host and the MCE injection code
>> >  in qemu-kvm are exercised.
>> >
>> >  Signed-off-by: Max Asbock<masbock@linux.vnet.ibm.com>
>> >  Signed-off-by: Jiajia Zheng<jiajia.zheng@intel.com>
>> >  Signed-off-by: Huang Ying<ying.huang@intel.com>
>>
>> Added missing cpu_physical_memory_unmap and applied, thanks.
>>
>
> This should have been copied to qemu-devel so that the monitor people 
> can review it.
>

It also breaks the build:
>
> I  CC    x86_64-softmmu/monitor.o
> cc1: warnings being treated as errors
> /var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c: 
> In function 'do_p2v':
> /var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c:2312: 
> error: cast to pointer from integer of different size
> make[1]: *** [monitor.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2

I've reverted it for now.  Please resubmit to qemu upstream 
(qemu-devel@nongnu.org).  I also suggest coming up with a better name 
for the command, and QMP support.

-- 
error compiling committee.c: too many arguments to function