From: Tomas Carnecky <tom@dbservice.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
David Michael Barr <david.barr@cordelta.com>
Subject: Re: [PATCH 5/6] Introduce the git fast-import-helper
Date: Sun, 03 Oct 2010 17:45:08 +0200 [thread overview]
Message-ID: <4CA8A504.50009@dbservice.com> (raw)
In-Reply-To: <20101003153144.GA18001@burratino>
On 10/3/10 5:31 PM, Jonathan Nieder wrote:
> Tomas Carnecky wrote:
>
>> fast-import-helper.c | 2201 ++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Aaa! Could someone send a diff of this against the usual fast-import.c?
>
> I'm sure you won't be surprised to hear I am not optimistic about the
> long-term maintainability of two separate fast-import implementations.
> If we get usability improvements by patching the existing fast-import,
> that would be much better.
I agree. But when I started hacking on fast-import it seemed easier to
completely rip out parts that I didn't need and then add the few bits
that I needed. I only need two new things from fast-import:
1) support non-numeric marks (and even this is maybe not strictly
required)
2) dump the mark->sha1 mapping immediately after creating the object
(I heard there is a patch somewhere that does just that)
All other changes are not needed. Though I think there are a few things
which could be ported back to fast-import.c. I'll try to see which
changes make sense to be backported and will post patches.
tom
next prev parent reply other threads:[~2010-10-03 15:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 11:33 [RFC] New type of remote helpers Tomas Carnecky
2010-10-03 12:21 ` [PATCH 1/6] Remote helper: accept ':<value> <name>' as a response to 'list' Tomas Carnecky
2010-10-05 2:00 ` Jonathan Nieder
2010-10-07 21:17 ` Sverre Rabbelier
2010-10-03 12:21 ` [PATCH 2/6] Allow more than one keepfile in the transport Tomas Carnecky
2010-10-05 2:11 ` Jonathan Nieder
2010-10-03 12:21 ` [PATCH 3/6] Allow the transport fetch command to add additional refs Tomas Carnecky
2010-10-05 2:18 ` Jonathan Nieder
2010-10-03 12:21 ` [PATCH 4/6] Rename get_mode() to decode_tree_mode() and export it Tomas Carnecky
2010-10-05 2:23 ` Jonathan Nieder
2010-10-03 12:21 ` [PATCH 5/6] Introduce the git fast-import-helper Tomas Carnecky
2010-10-03 15:31 ` Jonathan Nieder
2010-10-03 15:45 ` Tomas Carnecky [this message]
2010-10-03 15:53 ` Sverre Rabbelier
2010-10-03 17:39 ` Tomas Carnecky
2010-10-03 23:15 ` Sverre Rabbelier
2010-10-03 12:21 ` [PATCH 6/6] Add git-remote-svn Tomas Carnecky
2010-10-05 2:26 ` Jonathan Nieder
2010-10-03 13:56 ` [RFC] New type of remote helpers Sverre Rabbelier
2010-10-03 15:13 ` Jonathan Nieder
2010-10-03 17:07 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA8A504.50009@dbservice.com \
--to=tom@dbservice.com \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.