From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
stable@kernel.org
Subject: Re: [PATCH] ALSA: HDA: Correctly apply position_fix quirks for ATI and VIA controllers
Date: Mon, 04 Oct 2010 13:37:48 +0200 [thread overview]
Message-ID: <4CA9BC8C.4030809@canonical.com> (raw)
In-Reply-To: <4CA9A951.2010604@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On 2010-10-04 12:15, David Henningsson wrote:
> Position_fix quirks for specific machines now override the default
> position_fix behavior for all HDA controllers.
>
> BugLink: http://launchpad.net/bugs/465942
> BugLink: http://launchpad.net/bugs/580749
> BugLink: http://launchpad.net/bugs/587546
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
...and here's the version for 2.6.35 and 2.6.32 stable trees.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[-- Attachment #2: 0001-ALSA-HDA-Correctly-apply-position_fix-quirks-for-ATI.patch --]
[-- Type: text/x-patch, Size: 1998 bytes --]
>From 693810d675f1923449d7d38893a614c975bd359c Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Mon, 4 Oct 2010 13:13:44 +0200
Subject: [PATCH] ALSA: HDA: Correctly apply position_fix quirks for ATI and VIA controllers
BugLink: http://launchpad.net/bugs/465942
BugLink: http://launchpad.net/bugs/580749
BugLink: http://launchpad.net/bugs/587546
Position_fix quirks for specific machines now override the default
position_fix behavior for all HDA controllers.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/hda_intel.c | 21 ++++++++++++---------
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 741ad32..51b088e 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2264,12 +2264,24 @@ static int __devinit check_position_fix(struct azx *chip, int fix)
{
const struct snd_pci_quirk *q;
+ chip->via_dmapos_patch = 0;
+
switch (fix) {
case POS_FIX_LPIB:
case POS_FIX_POSBUF:
return fix;
}
+ q = snd_pci_quirk_lookup(chip->pci, position_fix_list);
+ if (q) {
+ /* Note that this implicitly sets via_dmapos_patch to zero */
+ printk(KERN_INFO
+ "hda_intel: position_fix set to %d "
+ "for device %04x:%04x\n",
+ q->value, q->subvendor, q->subdevice);
+ return q->value;
+ }
+
/* Check VIA/ATI HD Audio Controller exist */
switch (chip->driver_type) {
case AZX_DRIVER_VIA:
@@ -2278,16 +2290,7 @@ static int __devinit check_position_fix(struct azx *chip, int fix)
/* Use link position directly, avoid any transfer problem. */
return POS_FIX_LPIB;
}
- chip->via_dmapos_patch = 0;
- q = snd_pci_quirk_lookup(chip->pci, position_fix_list);
- if (q) {
- printk(KERN_INFO
- "hda_intel: position_fix set to %d "
- "for device %04x:%04x\n",
- q->value, q->subvendor, q->subdevice);
- return q->value;
- }
return POS_FIX_AUTO;
}
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-10-04 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 10:15 [PATCH] ALSA: HDA: Correctly apply position_fix quirks for ATI and VIA controllers David Henningsson
2010-10-04 11:37 ` David Henningsson [this message]
2010-10-22 16:00 ` [stable] " Greg KH
2010-10-12 10:36 ` [RESEND] " David Henningsson
2010-10-12 11:05 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9BC8C.4030809@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=stable@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.