From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36427 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2kc7-0002sY-7Q for qemu-devel@nongnu.org; Mon, 04 Oct 2010 08:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P2kc6-0002WE-4B for qemu-devel@nongnu.org; Mon, 04 Oct 2010 08:57:55 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:50003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P2kc5-0002Vl-MU for qemu-devel@nongnu.org; Mon, 04 Oct 2010 08:57:54 -0400 Message-ID: <4CA9CF3B.9030400@mail.berlios.de> Date: Mon, 04 Oct 2010 14:57:31 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] eepro100: Add support for multiple individual addresses (multiple IA) References: <4CA38D83.9040106@mail.berlios.de> <1285790395-25460-1-git-send-email-weil@mail.berlios.de> <20100929203010.GA7472@laped.lan> <20101003095653.GA16313@redhat.com> <4CA856DB.2070805@mail.berlios.de> <20101003111635.GC17133@redhat.com> <4CA86D61.3080200@mail.berlios.de> <20101003132051.GC19184@redhat.com> In-Reply-To: <20101003132051.GC19184@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: "Edgar E. Iglesias" , Dunc , QEMU Developers Am 03.10.2010 15:20, schrieb Michael S. Tsirkin: > On Sun, Oct 03, 2010 at 01:47:45PM +0200, Stefan Weil wrote: >>>> It might be applied to the stable branches, too. >>>> >>>> Thanks, >>>> Stefan >>> >>> To me, this doesn't look like a stable branch material: this adds is a >>> new feature, not a bugfix. Which guests benefit and how does >>> one use the routing emulation? >> >> >> The first mail in this thread should answer your question. >> >> It depends on your point of view whether better emulation >> adds a new feature or fixes a bug: > > When in doubt, excercise caution. But in the end, I think it's your call: > do you want this in 0.13 stable, too? Yes. The patch is strictly limited to eepro100.c, and even there its risk is limited to a highly specialized functionality. On the other side we get a stable version 0.13 with increased usability for a lot of people who use qemu with eepro100 to emulate their routers. Therefore it would be good to have this patch in 0.13 as well. Regards, Stefan