Re: cups issue

["Eric Bénard" <eric@eukrea.com>]

Hi Frans,

Le 04/10/2010 19:17, Frans Meulenbroeks a écrit :
> No idea who is the maintainer of cups, but I found the following issue:
>
> /etc/init.d/cups refers to ps ax but if you have busybox installed
> there are no ax options.
> As busybox has configurable columns it does not seem too good to fix
> cups to be able to handle both procps ps and busybox ps.
> Guess the preferred solution is to add a dependency to procps and get
> the real thing.
>
> However when wanting to make that change I bumped into the following:
>
> We have 6 cups recipes:
>
> cups_1.1.23.bb  cups_1.2.12.bb  cups_1.2.7.bb  cups_1.3.8.bb
> cups_1.4.3.bb  cups_1.4.4.bb
>
> The last three (!) of them have DP = "-1"
> Is there a point in add ing a recipe that has DP = "-1" for a
> prolonged time, then create a new version with DP = -1?
> (btw: and no version is pinned or so).
>
> Guess this recipe needs some love.
>
> (btw cups 1.4.4 solves a number of security issues; guess the best way
> forward is to test 1.4.4, then rm the old insecure stuff).
>
we are using 1.4.4 on armv5te and that works fine. I have a patch 
concerning the ps ax init the init file which does :
if [ /bin/ps -ef /bin/busybox ]; then
    pid=`ps w | awk '{if (match($5, ".*/cupsd$") || $5 == "cupsd") print 
$1}'`
else
    pid=`ps ax | awk '{if (match($5, ".*/cupsd$") || $5 == "cupsd") 
print $1}'`
fi

so it can handle both case fine.
I can push it if this is an acceptable solution.

Eric