From: Zachary Amsden <zamsden@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com, avi@redhat.com
Subject: Re: last_kernel_ns ?
Date: Mon, 04 Oct 2010 11:49:00 -1000 [thread overview]
Message-ID: <4CAA4BCC.2010303@redhat.com> (raw)
In-Reply-To: <20101004165004.GI1230@mothafucka.localdomain>
On 10/04/2010 06:50 AM, Glauber Costa wrote:
> Zach,
>
> vcpu->hv_clock.tsc_timestamp = tsc_timestamp;
> vcpu->hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset;
> vcpu->last_kernel_ns = kernel_ns;<===== (1)
> vcpu->last_guest_tsc = tsc_timestamp;
> vcpu->hv_clock.flags = 0;
>
> If I understand your intention corretly, you should add kvmclock_offset to (1).
> Am I misinterpreting something?
>
No, last_kernel_ns is the last observed value of kernel_ns, not system
time. The kvmclock_offset may be modified since observation (unlikely,
yet possible), and should not be considered in this computation.
prev parent reply other threads:[~2010-10-04 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 16:50 last_kernel_ns ? Glauber Costa
2010-10-04 21:49 ` Zachary Amsden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA4BCC.2010303@redhat.com \
--to=zamsden@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.