From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] packed attribute problem
Date: Tue, 5 Oct 2010 09:15:36 +0530 [thread overview]
Message-ID: <4CAA9F60.9000007@st.com> (raw)
In-Reply-To: <4CA9CC04.5020800@emk-elektronik.de>
On 10/4/2010 6:13 PM, Reinhard Meyer wrote:
>> > bar:
>> > @ Function supports interworking.
>> > @ args = 0, pretend = 0, frame = 0
>> > @ frame_needed = 0, uses_anonymous_args = 0
>> > @ link register save eliminated.
>> > @ lr needed for prologue
>> > mov r2, #5
>> > mov r3, #4096
>> > str r2, [r3, #0]
>> > bx lr
>> > .size bar, .-bar
>> > .ident "GCC: (GNU) 4.2.2"
>> >
>> >
>> > Note that this is with GCC 4.2.2. Even GCC 4.0.0 behaves the same, so
>> > this is *not* an issue with very recent tool chains.
> OK, for directly adressing elements inside a packed struct;
> but the original post said:
>
> "struct xyz {
> int x;
> int y;
> int z[CONST];
> } __attribute__ ((packed));
>
> struct xyz *abc;
> u32 * status_reg = (u32 *)&abc->z[0];
>
> writel(status, status_reg);"
>
> So the "status_reg" pointer is in a completely unrelated (to the packed struct)
> "u32 *" and still the access is done like it was packed. If the
> compiler silently drags that attribute along into the "u32 *"
> THAT is really sick!
>
Yes, This is exactly what I wanted to point out. I can see this behavior with
gcc-4.5.0 but the same code works well with gcc-4.2.4
Vipin
next prev parent reply other threads:[~2010-10-05 3:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 9:38 [U-Boot] packed attribute problem Vipin Kumar
2010-10-04 10:17 ` Wolfgang Denk
2010-10-04 10:30 ` Vipin Kumar
2010-10-04 10:44 ` Wolfgang Denk
2010-10-04 10:56 ` Reinhard Meyer
2010-10-04 11:01 ` Vipin Kumar
2010-10-04 11:46 ` Reinhard Meyer
2010-10-04 12:29 ` Wolfgang Denk
2010-10-04 12:43 ` Reinhard Meyer
2010-10-04 12:50 ` Balau
2010-10-04 12:58 ` Wolfgang Denk
2010-10-04 13:02 ` [U-Boot] DDR SPD table sywang
2010-10-04 15:56 ` Mike Frysinger
2010-10-04 12:56 ` [U-Boot] packed attribute problem Wolfgang Denk
2010-10-05 3:45 ` Vipin Kumar [this message]
2010-10-05 11:43 ` Detlev Zundel
2010-10-05 18:03 ` Scott Wood
2010-10-07 9:59 ` Detlev Zundel
2010-10-07 16:46 ` Scott Wood
2010-10-07 17:57 ` Wolfgang Denk
2010-10-07 18:52 ` Scott Wood
2010-10-07 19:31 ` Wolfgang Denk
2010-10-07 20:15 ` Scott Wood
2010-10-11 11:32 ` Detlev Zundel
2010-10-11 13:22 ` Balau
2010-10-04 10:57 ` Vipin Kumar
2010-10-04 12:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA9F60.9000007@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.