From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 00/14] cifs: clean up management of open filehandles
Date: Tue, 05 Oct 2010 16:00:19 +0530 [thread overview]
Message-ID: <4CAAFE3B.6080707@suse.de> (raw)
In-Reply-To: <1286214781-626-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 10/04/2010 11:22 PM, Jeff Layton wrote:
> This patchset fixes a number of problems with the existing CIFS code. It
> eliminates the backreference to the filp from cifsFileInfo, allowing a
> cifsFileInfo to outlive the filp that it was generated against.
>
> With that change, most of the closing of a filehandle on the server is
> moved to cifsFileInfo_put. cifs_close is then changed to just put the
> filehandle instead of trying to wait around for existing users to
> finish with it.
>
> With this change, there is some further cleanup that can be done as
> well. For instance, there's no real need to continually search for new
> filehandles in cifs_writepages now that we hold a reference to one. I'll
> hold back on that until I know how this set has been received.
>
Nice cleanups. Patches 1 to 9 looks correct to me.
Reviewed-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
prev parent reply other threads:[~2010-10-05 10:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 17:52 [PATCH 00/14] cifs: clean up management of open filehandles Jeff Layton
[not found] ` <1286214781-626-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-04 17:52 ` [PATCH 01/14] cifs: keep dentry reference in cifsFileInfo instead of inode reference Jeff Layton
2010-10-04 17:52 ` [PATCH 02/14] cifs: don't use vfsmount to pin superblock for oplock breaks Jeff Layton
2010-10-04 17:52 ` [PATCH 03/14] cifs: eliminate cifs_posix_open_inode_helper Jeff Layton
2010-10-04 17:52 ` [PATCH 04/14] cifs: eliminate oflags option from cifs_new_fileinfo Jeff Layton
2010-10-04 17:52 ` [PATCH 05/14] cifs: eliminate the inode argument " Jeff Layton
2010-10-04 17:52 ` [PATCH 06/14] cifs: clean up cifs_reopen_file Jeff Layton
2010-10-04 17:52 ` [PATCH 07/14] cifs: cifs_write argument change and cleanup Jeff Layton
2010-10-04 17:52 ` [PATCH 08/14] cifs: eliminate pfile pointer from cifsFileInfo Jeff Layton
2010-10-04 17:52 ` [PATCH 09/14] cifs: move cifs_new_fileinfo to file.c Jeff Layton
2010-10-04 17:52 ` [PATCH 10/14] cifs: convert GlobalSMBSeslock from a rwlock to regular spinlock Jeff Layton
[not found] ` <1286214781-626-11-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-05 10:30 ` Suresh Jayaraman
[not found] ` <4CAAFE45.6070803-l3A5Bk7waGM@public.gmane.org>
2010-10-05 10:58 ` Jeff Layton
2010-10-04 17:52 ` [PATCH 11/14] cifs: move cifsFileInfo_put to file.c Jeff Layton
2010-10-04 17:52 ` [PATCH 12/14] cifs: move close processing from cifs_close to cifsFileInfo_put Jeff Layton
2010-10-04 17:53 ` [PATCH 13/14] cifs: wait for writeback to complete in cifs_flush Jeff Layton
2010-10-04 17:53 ` [PATCH 14/14] cifs: eliminate cifsInodeInfo->write_behind_rc Jeff Layton
2010-10-04 20:31 ` [PATCH 00/14] cifs: clean up management of open filehandles Dave Kleikamp
2010-10-05 10:30 ` Suresh Jayaraman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAAFE3B.6080707@suse.de \
--to=sjayaraman-l3a5bk7wagm@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.