From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41518 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P35Z1-0008H7-MI for qemu-devel@nongnu.org; Tue, 05 Oct 2010 07:20:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P35Xg-00059j-VE for qemu-devel@nongnu.org; Tue, 05 Oct 2010 07:18:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P35Xg-000598-OA for qemu-devel@nongnu.org; Tue, 05 Oct 2010 07:18:44 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o95BIgAx028778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Oct 2010 07:18:42 -0400 Message-ID: <4CAB0988.60501@redhat.com> Date: Tue, 05 Oct 2010 13:18:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20101005105943.GA17394@redhat.com> In-Reply-To: <20101005105943.GA17394@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: -global option parsing List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 10/05/10 12:59, Michael S. Tsirkin wrote: > -global virtio_net_pci.hahah=0 > > seems to be run, with an invalid option being > silently ignored. Is this intentional? It is a invalid driver which is ignored ... Invalid options *are* catched (try "virtio-net-pci.foo=42"). > I think failing with an error would be better ... Indeed. I think this needs a separate verification pass; IIRC the list of drivers (and busses, remember PCI.prop=something works too) doesn't exist yet at command line option parsing time. cheers, Gerd