All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Freyther <holger+oe@freyther.de>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Latest qt4-sdk-tools* patch is wrong
Date: Tue, 05 Oct 2010 22:01:33 +0800	[thread overview]
Message-ID: <4CAB2FBD.6060401@freyther.de> (raw)

Hi Dmitry,

your latest change is wrong. You apply a patch (that is not mentioned in the
commit message) that does not exist in the tree. Your patch to
qt4-tools-sdk.inc is also wrong. qt4-tools-sdk.inc is only used by
qt4-tools-sdk_4.7.0.bb which is using -embedded and -no-freetype... so adding
the patch and the extra includes is not correct (and you probably should have
bumped INC_PR in that file).

For Qt 4.6.3 I would propose building the tools with --no-freetype as we have
no interest in GUI anyway.

I hope you can fix that soon.

	thanks.



             reply	other threads:[~2010-10-05 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 14:01 Holger Freyther [this message]
2010-10-05 15:39 ` Latest qt4-sdk-tools* patch is wrong Dmitry Eremin-Solenikov
2010-10-05 15:47   ` Holger Freyther
2010-10-05 20:13     ` Dmitry Eremin-Solenikov
2010-10-05 20:20       ` Holger Freyther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB2FBD.6060401@freyther.de \
    --to=holger+oe@freyther.de \
    --cc=dbaryshkov@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.