From: Andreas Oberritter <obi@linuxtv.org>
To: Jan Hoogenraad <jan-conceptronic@hoogenraad.net>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: Confusing dmx_pes_type_t in dmx.h
Date: Tue, 05 Oct 2010 16:05:17 +0200 [thread overview]
Message-ID: <4CAB309D.5020309@linuxtv.org> (raw)
In-Reply-To: <4CAAC57B.4000604@hoogenraad.net>
On 05.10.2010 08:28, Jan Hoogenraad wrote:
> The file dmx.h declares dmx_pes_type_t which is ONLY used in this header
> file.
> It is easy to make mistakes, as its member DMX_PES_OTHER resembles a
> similar symbol in demux.h from enum dmx_ts_pes: DMX_TS_PES_OTHER
>
> One problem was found because of Hans' compiler upgrade.
>
> I think it would be safer (because it is easy to make mistakes) to
> remove dmx_pes_type_t from dmx.h.
The file dmx.h defines the interface for userspace applications, hence
dmx_pes_type_t must not be removed. Instead, removing enum dmx_ts_pes
from demux.h seems to be useful to me.
Regards,
Andreas
prev parent reply other threads:[~2010-10-05 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 6:28 Confusing dmx_pes_type_t in dmx.h Jan Hoogenraad
2010-10-05 14:05 ` Andreas Oberritter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAB309D.5020309@linuxtv.org \
--to=obi@linuxtv.org \
--cc=hverkuil@xs4all.nl \
--cc=jan-conceptronic@hoogenraad.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.