From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh kumar Subject: Re: [PATCH V2 21/69] Keyboard: Adding support for spear-keyboard Date: Wed, 6 Oct 2010 09:28:24 +0530 Message-ID: <4CABF3E0.8010909@st.com> References: <584e4ecc7883807e1fae0e6c53b2837954935e53.1285933331.git.viresh.kumar@st.com> <20101005154737.GA19730@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101005154737.GA19730-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org" , "dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rajeev KUMAR , Shiraz HASHIM , Vipin KUMAR , Deepak SIKRI , Armando VISCONTI , Vipul Kumar SAMAR , Pratyush ANAND , Bhupesh SHARMA List-Id: linux-input@vger.kernel.org On 10/05/2010 09:17 PM, Dmitry Torokhov wrote: > As discussed previously I'd like to see the driver using as much of > matrix_keypad infrastructure as practical and also to see the initial > keypad copied into the spear_kbd structure to ensure that the board code > could be made const and bind/rebind of the device would restore the > original keymap. > Dmitry, As suggested in V1, we have used KEY() macro from matrix_keypad.h file. Also we are allocating memory for keymap in driver itself in probe. Then we are copying keymap in from plat data. This makes it restore to original keymap on every bind/rebind of device. Is there anything else we need to do?? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Wed, 6 Oct 2010 09:28:24 +0530 Subject: [PATCH V2 21/69] Keyboard: Adding support for spear-keyboard In-Reply-To: <20101005154737.GA19730@core.coreip.homeip.net> References: <584e4ecc7883807e1fae0e6c53b2837954935e53.1285933331.git.viresh.kumar@st.com> <20101005154737.GA19730@core.coreip.homeip.net> Message-ID: <4CABF3E0.8010909@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/05/2010 09:17 PM, Dmitry Torokhov wrote: > As discussed previously I'd like to see the driver using as much of > matrix_keypad infrastructure as practical and also to see the initial > keypad copied into the spear_kbd structure to ensure that the board code > could be made const and bind/rebind of the device would restore the > original keymap. > Dmitry, As suggested in V1, we have used KEY() macro from matrix_keypad.h file. Also we are allocating memory for keymap in driver itself in probe. Then we are copying keymap in from plat data. This makes it restore to original keymap on every bind/rebind of device. Is there anything else we need to do?? -- viresh