From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh kumar Subject: Re: [PATCH V2 21/69] Keyboard: Adding support for spear-keyboard Date: Wed, 6 Oct 2010 12:41:56 +0530 Message-ID: <4CAC213C.9080506@st.com> References: <584e4ecc7883807e1fae0e6c53b2837954935e53.1285933331.git.viresh.kumar@st.com> <20101005154737.GA19730@core.coreip.homeip.net> <4CABF3E0.8010909@st.com> <20101006061652.GA14609@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from eu1sys200aog118.obsmtp.com ([207.126.144.145]:45593 "EHLO eu1sys200aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758637Ab0JFHMl (ORCPT ); Wed, 6 Oct 2010 03:12:41 -0400 In-Reply-To: <20101006061652.GA14609@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: "linux-arm-kernel@lists.infradead.org" , "rtc-linux@googlegroups.com" , "a.zummo@towertech.it" , "dbrownell@users.sourceforge.net" , "linux-usb@vger.kernel.org" , "linux-input@vger.kernel.org" , Rajeev KUMAR , Shiraz HASHIM , Vipin KUMAR , Deepak SIKRI , Armando VISCONTI , Vipul Kumar SAMAR , Pratyush ANAND , Bhupesh SHARMA On 10/06/2010 11:46 AM, Dmitry Torokhov wrote: > Sorry, did not look far enough in the patch and missed the separate > allocation. But do you really want to allocate it separately? I think > the following patch simplifies and speeds up things at the expense of > slightly larger keymap structure. > > There are also fixes for proper __devinit/__devexit markups, locking of > open/close vs suspend/resume, keymap can be changed from userspace via > EVIOCSKEYCODE and bunch of other changes. > > Thanks. > > -- > Dmitry > > > Input: spear-kbd - assorted changes > > Signed-off-by: Dmitry Torokhov > --- > > arch/arm/plat-spear/include/plat/keyboard.h | 3 > drivers/input/keyboard/spear-keyboard.c | 311 +++++++++++++-------------- > 2 files changed, 149 insertions(+), 165 deletions(-) Dmitry, We are busy with other activities, and can't test it right now. But i have reviewed it and it looks fine to me. Acked-by: Viresh Kumar Please include it in input-next repo. We will test it later on. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Wed, 6 Oct 2010 12:41:56 +0530 Subject: [PATCH V2 21/69] Keyboard: Adding support for spear-keyboard In-Reply-To: <20101006061652.GA14609@core.coreip.homeip.net> References: <584e4ecc7883807e1fae0e6c53b2837954935e53.1285933331.git.viresh.kumar@st.com> <20101005154737.GA19730@core.coreip.homeip.net> <4CABF3E0.8010909@st.com> <20101006061652.GA14609@core.coreip.homeip.net> Message-ID: <4CAC213C.9080506@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/06/2010 11:46 AM, Dmitry Torokhov wrote: > Sorry, did not look far enough in the patch and missed the separate > allocation. But do you really want to allocate it separately? I think > the following patch simplifies and speeds up things at the expense of > slightly larger keymap structure. > > There are also fixes for proper __devinit/__devexit markups, locking of > open/close vs suspend/resume, keymap can be changed from userspace via > EVIOCSKEYCODE and bunch of other changes. > > Thanks. > > -- > Dmitry > > > Input: spear-kbd - assorted changes > > Signed-off-by: Dmitry Torokhov > --- > > arch/arm/plat-spear/include/plat/keyboard.h | 3 > drivers/input/keyboard/spear-keyboard.c | 311 +++++++++++++-------------- > 2 files changed, 149 insertions(+), 165 deletions(-) Dmitry, We are busy with other activities, and can't test it right now. But i have reviewed it and it looks fine to me. Acked-by: Viresh Kumar Please include it in input-next repo. We will test it later on. -- viresh