From: Jiri Slaby <jirislaby@gmail.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Alan Ott <alan@signal11.us>, Oliver Neukum <oliver@neukum.name>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences
Date: Wed, 06 Oct 2010 12:09:07 +0200 [thread overview]
Message-ID: <4CAC4AC3.60507@gmail.com> (raw)
In-Reply-To: <20101006120129.52da81d3.ospite@studenti.unina.it>
On 10/06/2010 12:01 PM, Antonio Ospite wrote:
> On Tue, 05 Oct 2010 23:12:00 +0200
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> On 10/05/2010 05:20 PM, Antonio Ospite wrote:
>>> here are some fixes to hidraw.
>>>
>>> Patches are against 2.6.36-rc6, but they should be ported to other
>>> maintained stable kernels as well.
>>>
>>> Antonio Ospite (2):
>>> HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl
>>> HID: hidraw, fix a NULL pointer dereference in hidraw_write
>>
>> Hi, please fix also the window in hidraw_release.
>>
>
> I am not sure I get what you mean, can you please add more details?
Sure. Look at the code:
if (!hidraw_table[minor])
return -ENODEV;
...
dev = hidraw_table[minor];
if (!--dev->open) {
...
This is done without minors_lock, so you can easily have dev being NULL
even though the first if.
regards,
--
js
next prev parent reply other threads:[~2010-10-06 10:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 11:25 [PATCH] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Antonio Ospite
2010-10-04 13:50 ` Jiri Kosina
2010-10-04 14:11 ` Antonio Ospite
2010-10-05 15:20 ` [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences Antonio Ospite
2010-10-05 17:42 ` [stable] " Greg KH
2010-10-05 20:16 ` Antonio Ospite
2010-10-06 9:31 ` Jiri Kosina
2010-10-15 7:44 ` Antonio Ospite
2010-10-15 9:10 ` Jiri Kosina
2010-10-05 21:12 ` Jiri Slaby
2010-10-06 10:01 ` Antonio Ospite
2010-10-06 10:09 ` Jiri Slaby [this message]
2010-10-09 12:40 ` Antonio Ospite
2010-10-19 9:24 ` [PATCH 1/1] HID: hidraw, fix window in hidraw_release Jiri Slaby
2010-10-19 9:28 ` Jiri Slaby
2010-10-19 9:28 ` Jiri Slaby
2010-10-19 9:29 ` Jiri Slaby
2010-10-20 14:55 ` Jiri Kosina
2010-10-05 15:20 ` [PATCH 1/2] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Antonio Ospite
2010-10-05 15:20 ` [PATCH 2/2] HID: hidraw, fix a NULL pointer dereference in hidraw_write Antonio Ospite
2010-10-04 13:54 ` [PATCH] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Alan Ott
2010-10-05 20:29 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAC4AC3.60507@gmail.com \
--to=jirislaby@gmail.com \
--cc=alan@signal11.us \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.name \
--cc=ospite@studenti.unina.it \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.