From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Greg KH <greg@kroah.com>, linux-omap <linux-omap@vger.kernel.org>,
linux-main <linux-kernel@vger.kernel.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Tony Lindgren <tony@atomide.com>,
Hiroshi Doyu <hiroshi.doyu@nokia.com>
Subject: Re: [PATCH 0/2] omap: dsp: make the driver actually work
Date: Wed, 6 Oct 2010 20:32:48 -0500 [thread overview]
Message-ID: <4CAD2340.9040305@ti.com> (raw)
In-Reply-To: <AANLkTi=ENjWQRYitr_kYzmRKgve=CoBf=7Y5KHLJNLfb@mail.gmail.com>
On 10/5/2010 4:05 PM, Felipe Contreras wrote:
> On Tue, Oct 5, 2010 at 11:09 PM, Ramirez Luna,
> Omar<omar.ramirez@ti.com> wrote:
>> Felipe Contreras wrote:
...
>>
>> Hmmm, because my other option was to move the reserved memory
>> outside the kernel, but that involves specifying bootargs again and
>> using dma_alloc_coherent with their restrictions.
>
> Huh, if there's no contiguous memory region reserved, then the
> driver is doing dma_alloc_coherent already, but that fails
> (apparently 5M is too much). Plus I've read that dma_alloc_coherent
> is "precious"; shouldn't be used for that.
Initially bridge was using the memory on the upper part of the RAM,
specifying in bootargs mem=MAX-6MB, so reintroducing the parameter works
fine; dma_alloc_coherent was also used when bridge was compiled as
built-in the kernel but now it is not working either.
>
> So, first I wanted to try reserving some region with mem=X boot
> param, but that solution is ugly. If that worked, then I wanted ti
> see if flushing each time we access that shm memory block works, but
> in the process I wanted to reorganize the whole initialization code
> because right now it's very ugly and confusing.
>
Yes, I can help with that, I'm sending a patch to reintroduce the
parameter for phys_mempool_base, however we need to remove or disable
the memblock functions related with dspbridge. I was thinking of a
menuconfig parameter to specify mempool base for built-in compilation.
Regards,
Omar
prev parent reply other threads:[~2010-10-07 1:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 16:09 [PATCH 0/2] omap: dsp: make the driver actually work Felipe Contreras
2010-10-04 16:09 ` [PATCH 1/2] omap: add dsp platform device Felipe Contreras
2010-10-05 15:56 ` Greg KH
2010-10-05 16:28 ` Tony Lindgren
2010-10-05 19:04 ` Greg KH
2010-10-04 16:09 ` [PATCH 2/2] staging: tidspbridge: use omap_dsp_platform_data Felipe Contreras
2010-10-05 19:07 ` [PATCH 0/2] omap: dsp: make the driver actually work Greg KH
2010-10-05 19:23 ` Felipe Contreras
2010-10-05 19:52 ` Ramirez Luna, Omar
2010-10-05 20:02 ` Felipe Contreras
2010-10-05 20:09 ` Ramirez Luna, Omar
2010-10-05 21:05 ` Felipe Contreras
2010-10-07 1:32 ` Omar Ramirez Luna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAD2340.9040305@ti.com \
--to=omar.ramirez@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=greg@kroah.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.