From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34149 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3kzX-0002T6-4i
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:34:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kq5-00064H-5t
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:24:30 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:56020)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kq5-000643-0g
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:24:29 -0400
Received: by iwn38 with SMTP id 38so12466iwn.4
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 00:24:27 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CAD7565.5040909@redhat.com>
Date: Thu, 07 Oct 2010 09:23:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTi=f0aw0r0HAYmk7r_CpsueG5WZjf0A_Y_khiWW5@mail.gmail.com>
In-Reply-To: <AANLkTi=f0aw0r0HAYmk7r_CpsueG5WZjf0A_Y_khiWW5@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/06/2010 11:33 PM, Blue Swirl wrote:
> +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)
>           } else if (strncmp(options, "acl", 3) == 0) {
>               acl = 1;
> +#endif

Not sure it's okay to reject the option altogether (i.e. maybe the #if 
should only include "acl = 1".

Paolo