From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34024 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3kzN-0002Qf-3g
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:34:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3ktI-0006Y3-Io
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:27:49 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:55613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3ktI-0006U8-Cx
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:27:48 -0400
Received: by mail-iw0-f173.google.com with SMTP id 38so17737iwn.4
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 00:27:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CAD7670.10808@redhat.com>
Date: Thu, 07 Oct 2010 09:27:44 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTingc+SFvEk0TEY8kej27RmrmQU7eweui4Qmb2XQ@mail.gmail.com>
In-Reply-To: <AANLkTingc+SFvEk0TEY8kej27RmrmQU7eweui4Qmb2XQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/06/2010 11:32 PM, Blue Swirl wrote:
> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>           env->gpr[3] = 0;
>           break;
>       case 39: /* video_ctrl */
> -        if (env->gpr[6] == 0 || env->gpr[6] == 1)
> -            vga_vbl_enabled = env->gpr[6];
>           env->gpr[3] = 0;
>           break;
>       case 47:

NACK, this smells like an incomplete emulation.

Paolo