From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float.
Date: Thu, 07 Oct 2010 16:12:03 +0200 [thread overview]
Message-ID: <4CADD533.30404@redhat.com> (raw)
In-Reply-To: <m3d3ryji48.fsf@blackfin.pond.sub.org>
On 09/28/10 12:08, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>> index 49bcd8d..7f58fb2 100644
>> --- a/qemu-monitor.hx
>> +++ b/qemu-monitor.hx
>> @@ -1093,7 +1093,7 @@ EQMP
>>
>> {
>> .name = "migrate_set_speed",
>> - .args_type = "value:f",
>> + .args_type = "value:o",
>> .params = "value",
>> .help = "set maximum speed (in bytes) for migrations",
>> .user_print = monitor_user_noop,
>
> Doesn't this change the interpretation of "42" from 42 to (42 << 20)?
It was always so on the command line that a number without a specifier
meant MB. If the monitor defaulted to bytes it will get ugly to support
both defaults in common code.
Cheers,
Jes
next prev parent reply other threads:[~2010-10-07 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 14:52 [Qemu-devel] [PATCH v2 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-16 14:52 ` [Qemu-devel] [PATCH 1/5] Introduce strtobytes() library function to convert string to byte count Jes.Sorensen
2010-09-28 9:48 ` Markus Armbruster
2010-09-16 14:52 ` [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Jes.Sorensen
2010-09-28 9:56 ` Markus Armbruster
2010-09-16 14:52 ` [Qemu-devel] [PATCH 3/5] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-09-28 10:06 ` Markus Armbruster
2010-09-28 14:28 ` Luiz Capitulino
2010-09-16 14:52 ` [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-09-28 10:08 ` Markus Armbruster
2010-09-28 14:32 ` Luiz Capitulino
2010-10-07 14:12 ` Jes Sorensen [this message]
2010-09-16 14:52 ` [Qemu-devel] [PATCH 5/5] Remove obsolete 'f' double parameter type Jes.Sorensen
2010-09-28 10:08 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2010-09-15 12:23 [Qemu-devel] [PATCH 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CADD533.30404@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.