From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38740 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3vug-0000t8-H2
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P3vn4-0006Rg-1D
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:06:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P3vn3-0006QI-RA
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:06:05 -0400
Message-ID: <4CAE1A0D.7000704@redhat.com>
Date: Thu, 07 Oct 2010 21:05:49 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1286467084-5110-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1286467084-5110-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] configure: Send error message from spice
	check to /dev/null
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 10/07/10 17:58, Stefan Weil wrote:
> pkg-config is not always available (e.g. on win32 hosts),
> but we don't want to see the 'command not found' error message.

>   compile_object() {
> +  echo>>config.log
> +  cat $TMPC>>config.log
> +  echo>>config.log

This looks unrelated.

> @@ -28,6 +31,9 @@ compile_object() {
>   compile_prog() {
>     local_cflags="$1"
>     local_ldflags="$2"
> +  echo>>config.log
> +  cat $TMPC>>config.log
> +  echo>>config.log

This too.

>     spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
>     spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server&&\
> +  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \

Fine with me, the other pkgconfig calls are covered already, the third 
missing is just an oversight and the fix is ObliviouslyCorrect[tm].

cheers,
   Gerd