From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38517 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3vtr-0000ia-G4
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:13:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P3vsT-0008JK-Jq
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:11:42 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:65108)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P3vsT-0008J1-1l
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:11:41 -0400
Message-ID: <4CAE1B68.8030701@mail.berlios.de>
Date: Thu, 07 Oct 2010 21:11:36 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1286467084-5110-1-git-send-email-weil@mail.berlios.de>
	<4CAE1A0D.7000704@redhat.com>
In-Reply-To: <4CAE1A0D.7000704@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] configure: Send error message from spice
	check to /dev/null
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 07.10.2010 21:05, schrieb Gerd Hoffmann:
> On 10/07/10 17:58, Stefan Weil wrote:
>> pkg-config is not always available (e.g. on win32 hosts),
>> but we don't want to see the 'command not found' error message.
>
>>   compile_object() {
>> +  echo>>config.log
>> +  cat $TMPC>>config.log
>> +  echo>>config.log
>
> This looks unrelated.

Ups, that was the wrong patch (some test code).
Sorry - I'll fix that immediately.

Thanks for your feedback.

>
>> @@ -28,6 +31,9 @@ compile_object() {
>>   compile_prog() {
>>     local_cflags="$1"
>>     local_ldflags="$2"
>> +  echo>>config.log
>> +  cat $TMPC>>config.log
>> +  echo>>config.log
>
> This too.
>
>>     spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 
>> 2>/dev/null)
>>     spice_libs=$($pkgconfig --libs spice-protocol spice-server 
>> 2>/dev/null)
>> -  if $pkgconfig --atleast-version=0.5.3 spice-server&&\
>> +  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 
>> 2>&1&&  \
>
> Fine with me, the other pkgconfig calls are covered already, the third 
> missing is just an oversight and the fix is ObliviouslyCorrect[tm].
>
> cheers,
>   Gerd
>
>