From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37196 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3zgJ-00057L-Q4
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 19:15:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1P3zgI-0001xh-JG
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 19:15:23 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:48914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1P3zgI-0001xU-Gi
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 19:15:22 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o97MxqM3030072
	for <qemu-devel@nongnu.org>; Thu, 7 Oct 2010 18:59:52 -0400
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o97NFHK6097000
	for <qemu-devel@nongnu.org>; Thu, 7 Oct 2010 19:15:17 -0400
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id o97NFHbL009710
	for <qemu-devel@nongnu.org>; Thu, 7 Oct 2010 17:15:17 -0600
Message-ID: <4CAE5484.6060308@linux.vnet.ibm.com>
Date: Thu, 07 Oct 2010 16:15:16 -0700
From: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] fix unsigned comparison warning in TCG
References: <AANLkTikWWTDUqStdFZBOk=ZSv3dv70Ngc9gb-6UuWXuL@mail.gmail.com>
	<AANLkTi=AFOyVNAtvQ_1s6LW=S9WiW4Z6vkGOZWExctE6@mail.gmail.com>
In-Reply-To: <AANLkTi=AFOyVNAtvQ_1s6LW=S9WiW4Z6vkGOZWExctE6@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Hollis Blanchard <hollis@penguinppc.org>

On 9/26/2010 11:33 AM, Blue Swirl wrote:
> On Sun, Sep 26, 2010 at 5:40 PM, Hollis Blanchard <hollis@penguinppc.or=
g> wrote:
>> TCGOpcode is an enum, which apparently can be unsigned.
>>
>> Signed-off-by: Hollis Blanchard <hollis@penguinppc.org>
>> ---
>>
>> % ./configure --target-list=3Dppcemb-softmmu --enable-debug
>> % make
>>  ...
>>  CC    ppcemb-softmmu/tcg/tcg.o
>> cc1: warnings being treated as errors
>> /home/hollisb/source/qemu.git/tcg/tcg.c: In function
>> =E2=80=98tcg_add_target_add_op_defs=E2=80=99:
>> /home/hollisb/source/qemu.git/tcg/tcg.c:1030: error: comparison of
>> unsigned expression >=3D 0 is always true
>> % gcc -v
>> gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)
>>
>> diff --git a/tcg/tcg.c b/tcg/tcg.c
>> index e0a9030..7e96859 100644
>> --- a/tcg/tcg.c
>> +++ b/tcg/tcg.c
>> @@ -1027,7 +1027,7 @@ void tcg_add_target_add_op_defs(const TCGTargetO=
pDef *tdef
>>         if (tdefs->op =3D=3D (TCGOpcode)-1)
>>             break;
>>         op =3D tdefs->op;
>> -        assert(op >=3D 0 && op < NB_OPS);
>> +        assert(op < NB_OPS);
>=20
> Please add int cast, like 95ee3914bfd551aeec49932a400530141865acad.
>=20

What is the latest on this? Waiting for this fix as I use --enable-debug =
a lot. :)

- JV