[Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float.

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 10/07/10 18:03, Paolo Bonzini wrote:
> On 10/07/2010 05:01 PM, Jes.Sorensen@redhat.com wrote:
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 81999aa..95bdb91 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -754,7 +754,7 @@ ETEXI
>>
>>       {
>>           .name       = "migrate_set_speed",
>> -        .args_type  = "value:f",
>> +        .args_type  = "value:o",
>>           .params     = "value",
>>           .help       = "set maximum speed (in bytes) for migrations",
>                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Is this still accurate?
> 
> Alternatively, you said it's a mess to distinguish the defaults on the
> command line and the monitor, but is it harder than the attached patch?

I guess that depends on how you look at it, but I guess I could improve
the error message to make it clearer.

Cheers,
Jes