From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54700 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P49uK-0001eR-2q
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 06:10:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P49uJ-0004V0-1V
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 06:10:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46684)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P49uI-0004Uw-Q6
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 06:10:30 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o98AAUpu024022
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 8 Oct 2010 06:10:30 -0400
Message-ID: <4CAEEE36.3030903@redhat.com>
Date: Fri, 08 Oct 2010 12:11:02 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1286483105-9768-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1286483105-9768-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/2] qcow2_create() error handling fixes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org

Am 07.10.2010 22:25, schrieb Eduardo Habkost:
> From: Eduardo Habkost <ehabkost@raisama.net>
> 
> Hi,
> 
> Here are two small fixes on qcow2_create() error handling.
> 
> Eduardo Habkost (2):
>   fix fd leak on a qcow2_create2() error path
>   check for close() errors on qcow2_create()

A while ago I sent a patch to completely rewrite qcow_create using qemu
block layer functions. I didn't submit it for inclusion yet because it
makes some assumptions in qemu-iotests invalid and the test cases need
to be fixed first.

In the new version, your first patch wouldn't be needed. However, for
the second one, I think we have a problem today:

    void bdrv_close(BlockDriverState *bs);

We need to convert bdrv_close to be able to return error values and to
pass them on up to the first caller (which is qemu-img in this case).

I'll have a look at fixing the test cases and bdrv_close. If I can't get
it fixed easily, I'll consider your patches.

Kevin