From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35592 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4Bfc-0000sV-6m
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 08:03:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P4Bfa-0002wW-RB
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 08:03:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38509)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P4Bfa-0002wP-Kj
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 08:03:26 -0400
Message-ID: <4CAF08AB.4070205@redhat.com>
Date: Fri, 08 Oct 2010 14:03:55 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] ide: set WCACHE supported in IDENTIFY data
References: <20101004132941.GA26834@lst.de>
In-Reply-To: <20101004132941.GA26834@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 04.10.2010 15:29, schrieb Christoph Hellwig:
> ATA does not only have the WCACHE enabled bit in identify word 85, but also
> a WCACHE supported bit in word 82.  While the Linux kernel is fine with the
> latter at least hdparm also needs the former before correctly displaying
> the cache settings.  There's also a non-zero chance other operating systems
> are more picky in their volatile write cache detection.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied to the block branch.

Kevin