From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46102 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4GwV-0003hM-QN
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 13:41:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P4GkK-0003Xz-30
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 13:28:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P4GkJ-0003Xq-Sf
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 13:28:40 -0400
Message-ID: <4CAF54C2.90206@redhat.com>
Date: Fri, 08 Oct 2010 19:28:34 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTingc+SFvEk0TEY8kej27RmrmQU7eweui4Qmb2XQ@mail.gmail.com>
	<4CAD7670.10808@redhat.com>
	<AANLkTin9gKm-0YSDaZTwY-whSJqqTY6sfM-u7TwWx4hi@mail.gmail.com>
In-Reply-To: <AANLkTin9gKm-0YSDaZTwY-whSJqqTY6sfM-u7TwWx4hi@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 10/07/2010 07:24 PM, Blue Swirl wrote:
>> >  On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>> >>
>>> >>  @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>>> >>            env->gpr[3] = 0;
>>> >>            break;
>>> >>        case 39: /* video_ctrl */
>>> >>  -        if (env->gpr[6] == 0 || env->gpr[6] == 1)
>>> >>  -            vga_vbl_enabled = env->gpr[6];
>>> >>            env->gpr[3] = 0;
>>> >>            break;
>>> >>        case 47:
>> >
>> >  NACK, this smells like an incomplete emulation.
> Why would we care about unfinished temporary Mac-on-Linux hack for
> video.x? Perhaps the correct fix is to remove vga_osi_call function
> and env->osi_call field entirely.

CCing the person who could answer.

Paolo