Re: [PATCH v5 1/1] davinci: spi: replace existing driver

From: Michael Williamson <michael.williamson-wZX4cNJlHJ2sVWG7oymsAA@public.gmane.org>
To: "Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org"
	<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
	Brian Niebuhr <bniebuhr3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 1/1] davinci: spi: replace existing driver
Date: Fri, 08 Oct 2010 15:22:46 -0400	[thread overview]
Message-ID: <4CAF6F86.40201@criticallink.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59302342050C7-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>

Hi Sekhar,

On 10/6/2010 11:37 AM, Nori, Sekhar wrote:

> Hi Mike,
> 
> On Mon, Sep 20, 2010 at 23:12:53, Michael Williamson wrote:
>>
>> Let me know if you want testing on the DMA portion of the patch (when your ready, of course).
> 
> I just finished pushing the DMA related patches to the git branch[1].
> I have not tested yet, but feel free to give it a go (maybe I will get
> lucky again!).
>

I gave it a go for our platform.  The good news is, polled and interrupt driven mode still work!  
The bad news is that DMA mode hangs up the kernel on the first read attempt, stalled waiting 
for the transfer completion notification (hmmm.... I think this was a spot where things were 
tweaked a bit? :) )

I'll see if I can narrow it down some more if you don't get to it first.

> Also, do you have patches adding SPI support for DA850 platform?
> I can include these patches on this branch so others who will be
> testing don’t have to repeat the work.
> 

I cloned your repository at [1] and published the additions needed to made to test it on the
mitydsp-l138 platform (da850 based) at [2] (never mind the UART one at the end).  I had to add 
clock support for the spi devices and define the platform SPI resources/registration routines.  
I'd appreciate a quick peek at those to make sure that I didn't make any errors.  The spi 
registration may be refactorable (sp?) to support da830, I didn't look to closely at that.

If any of it is usable, great.

> Thanks,
> Sekhar
> 
> [1] http://arago-project.org/git/projects/?p=linux-davinci.git;a=shortlog;h=refs/heads/davinci-spi-rewrite
> 

[2] http://support.criticallink.com/gitweb/?p=linux-davinci.git;a=shortlog;h=refs/heads/spi-testing

-Mike
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source