All of lore.kernel.org
 help / color / mirror / Atom feed
From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] dove: add support for CM-A510 machine.
Date: Sun, 10 Oct 2010 08:46:45 +0200	[thread overview]
Message-ID: <4CB16155.6090002@compulab.co.il> (raw)
In-Reply-To: <AANLkTinVMczTFaQNyYinHdFzo1pzi2+SGHzrwikYCZFa@mail.gmail.com>

saeed bishara wrote:
> On Thu, Oct 7, 2010 at 9:36 AM, Konstantin Sinyuk
> <kostyas@compulab.co.il> wrote:
>> Signed-off-by: Konstantin Sinyuk <kostyas@compulab.co.il>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---

[ snip ]

>> +/* Board Init */
>> +static void __init cm_a510_init(void)
>> +{
>> +       /*
>> +        * Basic Dove setup. Needs to be called early.
>> +        */
>> +       dove_init();
>> +
>> +       dove_ge00_init(&cm_a510_ge00_data);
>> +       dove_ehci0_init();
>> +       dove_ehci1_init();
>> +       dove_sata_init(&cm_a510_sata_data);
>> +       dove_sdio0_init();
>> +       dove_sdio1_init();
>> +       dove_spi0_init();
>> +       dove_spi1_init();
>> +       dove_uart0_init();
>> +       dove_uart1_init();
>> +       dove_i2c_init();
>> +       spi_register_board_info(cm_a510_spi_flash_info,
>> +                               ARRAY_SIZE(cm_a510_spi_flash_info));
> Konstantin, are you sure your board has all the above interfaces?
> other than that the patch looks fine to me.

Our board indeed has all the above interfaces. Moreover, it uses other Dove 
interfaces that haven't yet hit the mainline.

>> +}
>> +
>> +MACHINE_START(CM_A510, "Compulab CM-A510 Board")
>> +       .phys_io        = DOVE_SB_REGS_PHYS_BASE,
>> +       .io_pg_offst    = ((DOVE_SB_REGS_VIRT_BASE) >> 18) & 0xfffc,
>> +       .boot_params    = 0x00000100,
>> +       .init_machine   = cm_a510_init,
>> +       .map_io         = dove_map_io,
>> +       .init_irq       = dove_init_irq,
>> +       .timer          = &dove_timer,
>> +MACHINE_END
>> --
>> 1.7.0.4


-- 
Sincerely yours,
Mike.

  reply	other threads:[~2010-10-10  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  7:36 [PATCH] [ARM] dove: add support for CM-A510 machine Konstantin Sinyuk
2010-10-07 17:44 ` saeed bishara
2010-10-10  6:46   ` Mike Rapoport [this message]
2010-10-13  7:41 ` Mike Rapoport
2010-11-10 13:18   ` Russell King - ARM Linux
2010-11-10 13:32     ` Eric Miao
2010-11-10 13:42     ` saeed bishara
2010-11-10 13:45       ` Russell King - ARM Linux
2010-11-10 13:51         ` saeed bishara
2010-11-10 14:28       ` Mike Rapoport
2010-11-10 21:12     ` Nicolas Pitre
2010-11-11 10:59       ` Mike Rapoport
2010-11-11 16:18         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB16155.6090002@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.