Re: [PATCH] isimodem: add some ss error enums

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

Hi Pekka,

> +const char *ss_gsm_error_name(enum ss_gsm_error value)
> +{
> +	switch (value) {
> +	_(SS_GSM_UNKNOWN_SUBSCRIBER);
> +	_(SS_GSM_ILLEGAL_SUBSCRIBER);
> +	_(SS_GSM_BEARER_SERV_NOT_PROVISION);

<snip>

> +
> +const char *ss_other_error_name(enum ss_other_error value)
> +{
> +	switch ((int)value) {
> +		_(SS_SERVICE_BUSY);
> +		_(SS_GSM_MM_RELEASE);
> +		_(SS_GSM_DATA_ERROR);

Can be consistent with switch/case indentation?

<snip>

> +enum ss_other_error {
> +	SS_SERVICE_BUSY =			0x00,
> +	SS_GSM_MM_RELEASE =			0x01,
> +	SS_GSM_DATA_ERROR =			0x02,
> +	SS_GSM_TIMER_EXPIRED =			0x03,
> +	SS_GSM_REQUEST_CANCELLED =		0x04,
> +	SS_GSM_INDICATE_DEVICE_PASSWORD =	0x05,
> +	SS_GSM_ACTIVATION_DATA_LOST =		0x09,
> +	SS_GSM_MM_ERROR =			0x0B,
> +	SS_GSM_SERVICE_NOT_ON_FDN_LIST =	0x0C,
> +	SS_SIMATKCC_REJECTED =			0x0D,
> +	SS_SIMATKCC_MODIFIED =			0x0E,
> +	SS_CS_INACTIVE =			0x0F,
> +	/* SS_GSM_SS_NOT_AVAILABLE =		0x12, */
> +	/* SS_GSM_USSD_BUSY =			0x48, */

Why are these commented out?

> +};
> +
>  #endif /* __ISIMODEM_SS_H */

Regards,
-Denis