All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation
Date: Sun, 10 Oct 2010 19:53:53 +0400	[thread overview]
Message-ID: <4CB1E191.90003@mvista.com> (raw)
In-Reply-To: <AANLkTinj12780G_QNrgeDOEXq8g5U9urx26f05jKxrNe@mail.gmail.com>

On 10-10-2010 19:47, Steve Sakoman wrote:

>>>>> The crash was occuring in env_relocate because it was being called prior
>>>>> to mmc_initialize.  This patch moves the MMC initialization earlier in
>>>>> the init process.

>>>>> This patch also cleans up the env_relocate_spec code in env_mmc.c

>>>>> Developed jointly with Stefano Babic

>>>>> Signed-off-by: Steve Sakoman<steve.sakoman@linaro.org>
>>>>> ---

>>>>> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
>>>>> index 5f2dfd0..0e2f129 100644
>>>>> --- a/arch/arm/lib/board.c
>>>>> +++ b/arch/arm/lib/board.c
>>>>> @@ -779,6 +779,11 @@ void board_init_r (gd_t *id, ulong dest_addr)
>>>>>        onenand_init();
>>>>>    #endif
>>>>>
>>>>> +#ifdef CONFIG_GENERIC_MMC
>>>>> +       puts ("MMC:   ");
>>>>> +       mmc_initialize (bd);

>>>>     This would cause checkpatch.pl to complain -- no spaces allowed before
>>>> (.

>>> I  will resubmit a V2 with that change as well as Stefano's Signed-off-by

>>    You've posted V2 with Stefano's ACK... and this line unchanged. :-)

> ???

> +#ifdef CONFIG_GENERIC_MMC
> +       puts("MMC:   ");
> +       mmc_initialize (bd);
> +#endif
> +

> It looks changed to me!

    Indeed, I have ovelooked that first line under #ifdef was changed. But not 
the second. ;-)

> Steve

WBR, Sergei

  reply	other threads:[~2010-10-10 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 21:49 [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation Steve Sakoman
2010-10-09 21:49 ` Paulraj, Sandeep
2010-10-10  9:27   ` stefano babic
2010-10-10 11:46 ` Sergei Shtylyov
2010-10-10 13:42   ` Steve Sakoman
2010-10-10 14:52     ` Sergei Shtylyov
2010-10-10 15:47       ` Steve Sakoman
2010-10-10 15:53         ` Sergei Shtylyov [this message]
2010-10-10 20:08           ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB1E191.90003@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.