Re: [PATCH 3/3] ath9k: built-in rate control A-MPDU fix

[Felix Fietkau <nbd@openwrt.org>]

On 2010-10-10 10:51 PM, Björn Smedman wrote:
> This patch attempts to ensure that ath9k's built-in rate control algorithm 
> does not rely on the value of the ampdu_len and ampdu_ack_len tx status 
> fields unless the IEEE80211_TX_STAT_AMPDU flag is set.
> 
> This patch has not been tested.
> 
> Cc: <stable@kernel.org>
> Signed-off-by: Björn Smedman <bjorn.smedman@venatech.se>
> ---
> diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
> index ce1cd6d..13f9e88 100644
> --- a/drivers/net/wireless/ath/ath9k/rc.c
> +++ b/drivers/net/wireless/ath/ath9k/rc.c
> @@ -1375,6 +1375,12 @@ static void ath_tx_status(void *priv, struct ieee80211_supported_band *sband,
>  	if (tx_info->flags & IEEE80211_TX_STAT_TX_FILTERED)
>  		return;
>  
> +	if (!(tx_info->flags & IEEE80211_TX_STAT_AMPDU)) {
> +		tx_info->status.ampdu_ack_len =
> +			(tx_info->flags & IEEE80211_TX_STAT_ACK ? 1 : 0);
> +		tx_info->status.ampdu_len = 1;
> +	}
> +
Shouldn't mac80211 do this instead?

- Felix