[Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/11/2010 02:52 PM, Markus Armbruster wrote:
> Warns about this line in check-qjson.c:
>      QObject *obj = qobject_from_json("");
>
> The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't
> work, because -Wall switches it on again.  Fix by putting configured
> flags last.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
> ---
>   configure |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index d303061..3a12f92 100755
> --- a/configure
> +++ b/configure
> @@ -146,7 +146,8 @@ QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"
>   LDFLAGS="-g $LDFLAGS"
>
>   gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
> -gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
> +gcc_flags="-Wformat-security -Wformat-y2k -Wno-format-zero-length $gcc_flags"
> +gcc_flags="-Winit-self -Wignored-qualifiers $gcc_flags"
>   gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
>   gcc_flags="-fstack-protector-all $gcc_flags"
>   cat>  $TMPC<<  EOF
> @@ -154,7 +155,7 @@ int main(void) { return 0; }
>   EOF
>   for flag in $gcc_flags; do
>       if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
> -	QEMU_CFLAGS="$flag $QEMU_CFLAGS"
> +	QEMU_CFLAGS="$QEMU_CFLAGS $flag"
>       fi
>   done
>

Acked-By: Paolo Bonzini <pbonzini@redhat.com>

Paolo