From: Tejun Heo <tj@kernel.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: core: use non-reentrant workqueue where necessary
Date: Mon, 11 Oct 2010 15:29:34 +0200 [thread overview]
Message-ID: <4CB3113E.1060403@kernel.org> (raw)
In-Reply-To: <tkrat.06dc43b96f9ab9bf@s5r6.in-berlin.de>
Hello, Stefan.
On 10/10/2010 04:55 PM, Stefan Richter wrote:
...
> Therefore queue all of these types of work items on system_nrt_wq
> instead of system_wq. The former guarantees non-reentrance across all
> CPUs, the latter only on the CPU which schedules a work item.
>
> As a bonus, other subsystems which flush system_wq won't be held up if
> the firewire subsystem spends a lot of time in an extraordinarily long
> fw_device.work.
Awesome, thanks a lot for doing this. BTW, I'm in the process of
hunting down all flush_scheduled_work() users and plan to remove
workqueue flushing capability from all system workqueues.
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
For the workqueue part,
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
next prev parent reply other threads:[~2010-10-11 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 14:55 [PATCH] firewire: core: use non-reentrant workqueue where necessary Stefan Richter
2010-10-10 14:57 ` [PATCH] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown Stefan Richter
2010-10-11 13:43 ` Tejun Heo
2010-10-11 21:27 ` Stefan Richter
2010-10-11 21:39 ` Stefan Richter
2010-10-12 13:55 ` Tejun Heo
2010-10-12 16:15 ` Stefan Richter
2010-10-12 16:46 ` Tejun Heo
2010-10-12 13:50 ` Tejun Heo
2010-10-12 21:39 ` [PATCH unfinished update] " Stefan Richter
2010-10-12 22:25 ` Stefan Richter
2010-10-12 23:09 ` Stefan Richter
2010-10-13 9:45 ` Tejun Heo
2010-10-11 13:29 ` Tejun Heo [this message]
2010-10-11 19:05 ` [PATCH] firewire: core: use non-reentrant workqueue where necessary Stefan Richter
2010-10-12 21:29 ` [PATCH update] firewire: core: use non-reentrant workqueue with rescuer Stefan Richter
2010-10-13 9:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB3113E.1060403@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.