From: Michal Marek <mmarek@suse.cz>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions
Date: Mon, 11 Oct 2010 16:39:21 +0200 [thread overview]
Message-ID: <4CB32199.1000401@suse.cz> (raw)
In-Reply-To: <20101007065438.GB12741@pengutronix.de>
On 7.10.2010 08:54, Wolfram Sang wrote:
> On Wed, Oct 06, 2010 at 04:31:31PM -0700, Joe Perches wrote:
>> + my $mode = $1;
>> + my $file = $2;
>> + if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
>> + WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
>> + }
>
> What about checking for no filename extension, too, and changing the message to
> something like "use proper file permission or proper extension"?
That would result in too many false positives, I'm afraid. What about
checking for files with a shebang?
Michal
next prev parent reply other threads:[~2010-10-11 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 23:31 [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions Joe Perches
2010-10-07 6:54 ` Wolfram Sang
2010-10-11 14:39 ` Michal Marek [this message]
2010-10-07 10:48 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB32199.1000401@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.