From: Bernhard Walle <walle@corscience.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: Add Lanai board USB clock type
Date: Mon, 11 Oct 2010 19:05:32 +0200 [thread overview]
Message-ID: <4CB343DC.3050506@corscience.de> (raw)
In-Reply-To: <4CB340F1.8020000@caviumnetworks.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Am 11.10.2010 18:53, schrieb David Daney:
> On 10/11/2010 03:09 AM, Bernhard Walle wrote:
>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It
>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
>>
>> Signed-off-by: Bernhard Walle<walle@corscience.de>
>> ---
>> drivers/staging/octeon/cvmx-helper-board.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> NAK.
>
> We don't currently support USB, so churning up this file doesn't help
> anything.
Well, agreed, but why not removing that code entirely then?
Regards,
Bernhard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]
next prev parent reply other threads:[~2010-10-11 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 10:09 [PATCH] staging: octeon: Add Lanai board USB clock type Bernhard Walle
2010-10-11 16:53 ` David Daney
2010-10-11 17:05 ` Bernhard Walle [this message]
2010-10-11 17:13 ` David Daney
2010-10-12 15:54 ` Greg KH
2010-10-12 16:56 ` David Daney
2010-10-13 16:39 ` Bernhard Walle
2010-10-13 21:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB343DC.3050506@corscience.de \
--to=walle@corscience.de \
--cc=ddaney@caviumnetworks.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.