All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless:  Support wiphy_renamed hook for drivers.
Date: Mon, 11 Oct 2010 12:07:09 -0700	[thread overview]
Message-ID: <4CB3605D.1040509@candelatech.com> (raw)
In-Reply-To: <1286822771.3634.85.camel@jlt3.sipsolutions.net>

On 10/11/2010 11:46 AM, Johannes Berg wrote:
> I think you should just do this (untested):

>   void
> @@ -892,8 +889,8 @@ ath5k_debug_init_device(struct ath5k_sof
>   {
>   	sc->debug.level = ath5k_debug;
>
> -	sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
> -				ath5k_global_debugfs);
> +	sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
> +				sc->hw->wiphy->debugfsdir);

This fails to work because sc->hw->wiphy->debugfsdir is null when this
method is called...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2010-10-11 19:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 18:42 [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers greearb
2010-10-11 18:42 ` [PATCH 2/2] ath5k: Support wiphy_renamed operation greearb
2010-10-11 18:43 ` [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers Johannes Berg
2010-10-11 18:46   ` Johannes Berg
2010-10-11 18:48     ` Ben Greear
2010-10-11 19:07     ` Ben Greear [this message]
2010-10-11 19:28       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB3605D.1040509@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.