Re: [GIT PATCHES FOR 2.6.37] Move V4L2 locking into the core framework

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em 11-10-2010 15:05, David Ellingsworth escreveu:
> On Mon, Oct 11, 2010 at 11:40 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On Sunday, October 10, 2010 19:33:48 David Ellingsworth wrote:

>>> Mauro, you should be ashamed for accepting a series that obviously has issues.
>>
>> Hardly obvious, and definitely not his fault.
>>
> 
> This comment was more general, since Mauro admitted having to make
> changes to your series to get it to compile under i386 architectures.
> 

So what? I always test if the tree compiles before sending the thing upstream. My
compilation is against i686 architecture, as it enables more drivers than other
architectures.

Rejecting a patch series just because of the lack of a typecast to remove a warning
on an architecture is not a good reason. I really prefer to apply the series and then
ask (or make a fix) to one or two lines, than to have to dig the entire patch series 
again on a rev 2 of the entire patch series. Examining a patch that fixes this issue
is a way easier than having to review a series of 11 patches.

Cheers,
Mauro.