From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 2 of 3] support of cpupools in xl: commands and library changes
Date: Tue, 12 Oct 2010 11:56:56 +0200 [thread overview]
Message-ID: <4CB430E8.4040004@ts.fujitsu.com> (raw)
In-Reply-To: <19636.12203.651041.734393@mariner.uk.xensource.com>
On 10/12/10 11:51, Ian Jackson wrote:
> Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes"):
>> tools/libxl/libxlu_cfg_l.c | 30 --
>> tools/libxl/libxlu_cfg_l.h | 18 -
>
> I see you reran flex. That's not wrong, but we shouldn't change these
> files needlessly, and you didn't make any changes to the .l source
> file, so when we apply this patch we should drop the changes to
> *_l.[ch].
I excluded these changes once before and was told they should be included...
I didn't call flex manually, this was done by make.
>
>> Renamed all cpu pool related names to *cpupool*
>
> Is that really true in this patch ? The function names and subcommand
> names in xl are still all "pool-*" and "pool_*".
There was no response to the question whether to change the sub-command names
or not. And I think the sub-command functions should reflect the names.
Juergen
--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
next prev parent reply other threads:[~2010-10-12 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 11:23 [PATCH 0 of 3] support of cpupools in xl Juergen Gross
2010-10-08 11:23 ` [PATCH 1 of 3] Support arbitrary numbers of physical cpus for cpupools in tools Juergen Gross
2010-10-08 11:23 ` [PATCH 2 of 3] support of cpupools in xl: commands and library changes Juergen Gross
2010-10-12 9:51 ` Ian Jackson
2010-10-12 9:56 ` Juergen Gross [this message]
2010-10-12 9:59 ` Ian Campbell
2010-10-12 10:43 ` Juergen Gross
2010-10-12 9:56 ` Ian Campbell
2010-10-08 11:23 ` [PATCH 3 of 3] add example cpupool config file Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2010-10-05 13:45 [PATCH 0 of 3] support of cpupools in xl Juergen Gross
2010-10-05 13:45 ` [PATCH 2 of 3] support of cpupools in xl: commands and library changes Juergen Gross
2010-10-06 13:31 ` Ian Campbell
2010-10-06 13:47 ` Gianni Tedesco
2010-10-08 8:41 ` Juergen Gross
2010-10-08 8:52 ` Ian Campbell
2010-10-08 9:21 ` Gianni Tedesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB430E8.4040004@ts.fujitsu.com \
--to=juergen.gross@ts.fujitsu.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.