From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 2 of 3] support of cpupools in xl: commands and library changes Date: Tue, 12 Oct 2010 12:43:58 +0200 Message-ID: <4CB43BEE.1020205@ts.fujitsu.com> References: <91397dcffead19270897.1286536984@nehalem1> <19636.12203.651041.734393@mariner.uk.xensource.com> <1286877571.2003.1739.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1286877571.2003.1739.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 10/12/10 11:59, Ian Campbell wrote: > On Tue, 2010-10-12 at 10:51 +0100, Ian Jackson wrote: >> Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes"): >>> tools/libxl/libxlu_cfg_l.c | 30 -- >>> tools/libxl/libxlu_cfg_l.h | 18 - >> >> I see you reran flex. That's not wrong, but we shouldn't change these >> files needlessly, and you didn't make any changes to the .l source >> file, so when we apply this patch we should drop the changes to >> *_l.[ch]. >> >>> Renamed all cpu pool related names to *cpupool* >> >> Is that really true in this patch ? The function names and subcommand >> names in xl are still all "pool-*" and "pool_*". > > The subcommands names are the xm names, which I thought we needed to > keep for compatibility. > > We could add both cpupool- and pool- variants and deprecate the later. > Or perhaps these commands are not widely used (at least from scripts and > whatnot) and we can just change the name. I have no problems changing the names to cpupool-*. Do you think we should change the names for xm, too? This move should be ack'ed by Novell, as they have included the cpupool stuff in SLES11 SP1. I don't know if there are other users than Fujitsu (and we could change quite easily). An option would be to support both variants in xm and only cpupool-* in xl. CC-ing Jan. Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html