From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57227 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5n1m-0003z8-TO for qemu-devel@nongnu.org; Tue, 12 Oct 2010 18:09:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5n1l-0001kH-KB for qemu-devel@nongnu.org; Tue, 12 Oct 2010 18:08:58 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:41226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5n1l-0001k9-GU for qemu-devel@nongnu.org; Tue, 12 Oct 2010 18:08:57 -0400 Received: by qwh5 with SMTP id 5so2167227qwh.4 for ; Tue, 12 Oct 2010 15:08:57 -0700 (PDT) Message-ID: <4CB4DA82.3080805@codemonkey.ws> Date: Tue, 12 Oct 2010 17:00:34 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFT] qemu 0.13.0-rc3 References: <201010122134.o9CLYoxu005707@triton8.kn-bremen.de> In-Reply-To: <201010122134.o9CLYoxu005707@triton8.kn-bremen.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juergen Lock Cc: qemu-devel@nongnu.org On 10/12/2010 04:34 PM, Juergen Lock wrote: > In article<4CB38C82.1090403@linux.vnet.ibm.com> you write: > >> After suffering from a prolonged maintainer softlockup, I'm attempting >> to get 0.13.0 release process back on track. >> >> I've tagged qemu-0.13.0-rc3 in git which only carries a few changes >> since 0.13.0-rc1. Most notably, a series of updates from Kevin Wolf and >> Cam Macdonell's ivshmem device. >> >> I think we're pretty good testing wise for the final release but I >> wanted to offer a 24-hour window for last minute fixes. I'm only >> interested in the following: >> >> 1) Patches that are *tested* against the stable-0.13 branch that are >> already committed in master. Please tell me explicitly that you've >> tested the patch and how you've tested it. >> >> [...] >> > First tests: > > - vmmouse seems broken (or disabled? I don't see it in `info qdm'...) > I don't think vmmouse is part of qdev yet. > - to test arm emulation I tried booting my old zaurus images (-M terrier) > which failed (q&d fix below), and in the process also tested -M n800 > w/o an image which failed with: > > qemu-system-arm: Duplicate ID 'null' for chardev > Can't create serial device, empty char device > > and that I got fixed by cherry-picking this commit from master: > > 6a8aabd3c132188ee8e0e82ef4aba09f782cbe96 > > From: Stefan Weil > Date: Sun, 8 Aug 2010 14:09:26 +0200 > Subject: [PATCH] hw/omap: Fix default setup for OMAP UART devices > Sorry, is the patch below an additional fix? If so, please submit against master. Regards, Anthony Liguori > ========== > > And the zaurus patch, problem was the 2nd scoop's base address > (0x08800040) gets rounded down to start of page which causes its > io read/write callbacks to be passed addresses 0x40 higher than > the code expects: (as witnessed by "Bad register offset" messages > and failure to attach the internal CF disk aka microdrive at least.) > > Signed-off-by: Juergen Lock > > --- a/hw/zaurus.c > +++ b/hw/zaurus.c > @@ -70,6 +70,10 @@ static uint32_t scoop_readb(void *opaque > { > ScoopInfo *s = (ScoopInfo *) opaque; > > + // XXX Workaround for base address (0x08800040 in this case) > + // rounded down to start of page > + addr&= 0x3f; > + > switch (addr) { > case SCOOP_MCR: > return s->mcr; > @@ -104,6 +108,10 @@ static void scoop_writeb(void *opaque, t > ScoopInfo *s = (ScoopInfo *) opaque; > value&= 0xffff; > > + // XXX Workaround for base address (0x08800040 in this case) > + // rounded down to start of page > + addr&= 0x3f; > + > switch (addr) { > case SCOOP_MCR: > s->mcr = value; > >