All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Avi Kivity <avi@redhat.com>
Subject: [PATCH] device-assignment: cleanup assigned_dev_ioport_map
Date: Wed, 13 Oct 2010 17:11:44 +0900	[thread overview]
Message-ID: <4CB569C0.6020905@jp.fujitsu.com> (raw)

Here we already have:
  AssignedDevRegion *region = &r_dev->v_addrs[region_num];

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
 hw/device-assignment.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 26cb797..975bf29 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -324,18 +324,12 @@ static void assigned_dev_ioport_map(PCIDevice *pci_dev, int region_num,
 	    kvm_ioperm(env, data);
     }
 
-    register_ioport_read(addr, size, 1, assigned_dev_ioport_readb,
-                         (r_dev->v_addrs + region_num));
-    register_ioport_read(addr, size, 2, assigned_dev_ioport_readw,
-                         (r_dev->v_addrs + region_num));
-    register_ioport_read(addr, size, 4, assigned_dev_ioport_readl,
-                         (r_dev->v_addrs + region_num));
-    register_ioport_write(addr, size, 1, assigned_dev_ioport_writeb,
-                          (r_dev->v_addrs + region_num));
-    register_ioport_write(addr, size, 2, assigned_dev_ioport_writew,
-                          (r_dev->v_addrs + region_num));
-    register_ioport_write(addr, size, 4, assigned_dev_ioport_writel,
-                          (r_dev->v_addrs + region_num));
+    register_ioport_read(addr, size, 1, assigned_dev_ioport_readb, region);
+    register_ioport_read(addr, size, 2, assigned_dev_ioport_readw, region);
+    register_ioport_read(addr, size, 4, assigned_dev_ioport_readl, region);
+    register_ioport_write(addr, size, 1, assigned_dev_ioport_writeb, region);
+    register_ioport_write(addr, size, 2, assigned_dev_ioport_writew, region);
+    register_ioport_write(addr, size, 4, assigned_dev_ioport_writel, region);
 }
 
 static uint32_t assigned_dev_pci_read(PCIDevice *d, int pos, int len)
-- 
1.7.3.1



                 reply	other threads:[~2010-10-13  8:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB569C0.6020905@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.