From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:43742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896Ab0JMOzx (ORCPT ); Wed, 13 Oct 2010 10:55:53 -0400 Message-ID: <4CB5C876.3030203@RedHat.com> Date: Wed, 13 Oct 2010 10:55:50 -0400 From: Steve Dickson To: Chuck Lever CC: linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/15] mountd: Clear mountd registrations at start up References: <20101010234836.6667.4057.stgit@ellison.1015granger.net> <20101011000411.6667.17979.stgit@ellison.1015granger.net> In-Reply-To: <20101011000411.6667.17979.stgit@ellison.1015granger.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 10/10/2010 08:04 PM, Chuck Lever wrote: > Clear stale MNT registrations before mountd tries to create fresh > listeners, to ensure that mountd starts. This is also what statd > does. > > Signed-off-by: Chuck Lever > --- > > utils/mountd/mountd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c > index d309950..7e0cf6a 100644 > --- a/utils/mountd/mountd.c > +++ b/utils/mountd/mountd.c > @@ -840,6 +840,7 @@ main(int argc, char **argv) > if (new_cache) > cache_open(); > > + unregister_services(); > if (version2()) { > listeners += nfs_svc_create("mountd", MOUNTPROG, > MOUNTVERS, mount_dispatch, port); > Question, since unregister_services() only unregisters version that are currently requested, won't it miss unregistering version that are not currently requested, ones that are left over from a previous instant of mountd? The point being all versions need to be unregistered at his point, not just the ones currently being requested. steved.