From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40971 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P63Z9-0005Z5-1p for qemu-devel@nongnu.org; Wed, 13 Oct 2010 11:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63Qs-0005sk-5j for qemu-devel@nongnu.org; Wed, 13 Oct 2010 11:40:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63Qr-0005sT-Vr for qemu-devel@nongnu.org; Wed, 13 Oct 2010 11:39:58 -0400 Message-ID: <4CB5D2ED.2060501@redhat.com> Date: Wed, 13 Oct 2010 17:40:29 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] [V2] Copy snapshots out of QCOW2 disk References: <1285124321-32556-1-git-send-email-disheng.su@gmail.com> In-Reply-To: <1285124321-32556-1-git-send-email-disheng.su@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: disheng.su@gmail.com Cc: qemu-devel@nongnu.org, edison Am 22.09.2010 04:58, schrieb disheng.su@gmail.com: > From: edison > > In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage. > The following patch adds a new option in "qemu-img": qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img. > Right now, it only supports to copy the full snapshot, delta snapshot is on the way. > > Changes from V1: all the comments from Kevin are addressed: > Add read-only checking > Fix coding style > Change the name from bdrv_snapshot_load to bdrv_snapshot_load_tmp > > Signed-off-by: Disheng Su Thanks, applied to the block branch. Kevin