From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Hypercalls from user-space
Date: Wed, 13 Oct 2010 09:45:38 -0700
Message-ID: <4CB5E232.40308@goop.org>
References: <C8D160B6.25395%keir@xen.org> <4CABA8C1.2060107@goop.org>
	<1286986809.2003.3551.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1286986809.2003.3551.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Keir Fraser <keir@xen.org>, "Srujan D. Kotikela" <ksrujandas@gmail.com>
List-Id: xen-devel@lists.xenproject.org

 On 10/13/2010 09:20 AM, Ian Campbell wrote:
> On Tue, 2010-10-05 at 23:37 +0100, Jeremy Fitzhardinge wrote:
>> On 10/05/2010 03:09 PM, Keir Fraser wrote:
>>> /proc/xen/privcmd should be available in domU as well. You might need to
>>> enable some dom0 build config options to get it though.
>> xenfs doesn't init privcmd on non-privileged kernels.
>>
>> Srujan, this should be enough to enable it in domU:
> I see you fixed this properly in 66d850da but I think you also need the
> following:

Oops, thanks.

    J

>
> Subject: build privcmd for domU now that it is exposed
>
> Fixes build error introduced in 66d850da "xen/privcmd: make privcmd
> visible in domU"
>
> drivers/built-in.o:(.data+0xd44): undefined reference to `privcmd_file_ops'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> diff --git a/drivers/xen/xenfs/Makefile b/drivers/xen/xenfs/Makefile
> index 4a0be9a..4fde944 100644
> --- a/drivers/xen/xenfs/Makefile
> +++ b/drivers/xen/xenfs/Makefile
> @@ -1,4 +1,4 @@
>  obj-$(CONFIG_XENFS) += xenfs.o
>  
> -xenfs-y			  = super.o xenbus.o
> -xenfs-$(CONFIG_XEN_DOM0) += xenstored.o privcmd.o
> +xenfs-y			  = super.o xenbus.o privcmd.o
> +xenfs-$(CONFIG_XEN_DOM0) += xenstored.o
>
>