Re: [PATCH] Check return value of fc_block_scsi_eh()

[Mike Christie <michaelc@cs.wisc.edu>]

On 10/13/2010 06:42 AM, Hannes Reinecke wrote:
>
> fc_block_scsi_eh() might return with status FAST_IO_FAIL
> indicating I/O has been terminated due to fast_io_fail timeout.
> In this case the rport is still blocked, so any error recovery
> will be failing on this port.
> Hence each driver needs to check if the return value from
> fc_block_scsi_eh() is something other than SUCCESS, in which
> case it should just return with that status.
> And we need to update the error handler to deal with a
> status of FAST_IO_FAIL, too.
> And fc_block_scsi_eh() should return SUCCESS on success,
> not 0. Otherwise the calling routine will become confused
> when reusing that value.
>

Is this patch supposed to fix the problem I described or is there more 
patches to follow or do you think I am being too paranoid? It seems the 
patch alone is going to make the problem worse in the drivers you are 
speeding up failure in. In the drivers now checking fc_block_scsi_eh and 
returning when fast io fail is returned then the scsi eh 
scsi_eh_flush_done_q's scsi_finish_command/scsi_queue_insert processing 
is going to get done faster and more likely to conflict with the 
termiante_rport_io callback processing, right?