From: David Daney <ddaney@caviumnetworks.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: Make TASK_SIZE reflect proper size for both 32 and 64 bit processes.
Date: Wed, 13 Oct 2010 14:46:10 -0700 [thread overview]
Message-ID: <4CB628A2.5060705@caviumnetworks.com> (raw)
In-Reply-To: <1286992415-21167-1-git-send-email-ddaney@caviumnetworks.com>
On 10/13/2010 10:53 AM, David Daney wrote:
[...]
>
> -#define __UA_LIMIT (- TASK_SIZE)
> +#define __UA_LIMIT (1ul<< 63)
>
This doesn't work:
Unhandled kernel unaligned access[#1]:
Cpu 7
$ 0 : 0000000000000000 10c38ca810c38c78 0000000000000000 0000000000000000
$ 4 : ffffffff811238ac 10c38ca810c38c68 0000000010108ce3 10c38ca810c38c68
$ 8 : 0000000000000000 10c38ca810c38c68 10c38ca810c38c68 10c38ca810c38c68
$12 : 0000000010108ce1 000000001000001e ffffffff8117aa08 ffffffff815905c8
$16 : ffffffffdca80000 a80000009271bcd0 8000000000000000 00000001208d0094
$20 : 10c38ca810c38c68 0000005558776460 ffffffffffffffa7 0000005558776428
$24 : 0000000000000000 0000005558aace60
$28 : a800000092718000 a80000009271bca0 0000005558776420 ffffffff81100880
Hi : 0000000000000249
Lo : 077c561f20000000
epc : ffffffff811238c4 do_ade+0x1f4/0x490
Not tainted
ra : ffffffff81100880 ret_from_exception+0x0/0x8
Status: 10108ce3 KX SX UX KERNEL EXL IE
Cause : 00800010
BadVA : 10c38ca810c38c68
PrId : 000d0409 (Cavium Octeon+)
Modules linked in:
Process loop-3.exe (pid: 31583, threadinfo=a800000092718000,
task=a8000000b6529fc8, tls=000000555c5ca880)
Stack : 0000000000000008 0000000000000080 10c38ca810c38c68 0000000000000008
00000001208d0094 ffffffff81100880 0000000000000000 10c38ca810c38c78
0000000000000000 8000000000000000 a80000009271be38 10c38ca810c38c68
0000000000000010 10c38ca810c38c68 0000000000000000 10c38ca810c38c68
10c38ca810c38c68 10c38ca810c38c68 0000000000000000 0000000000000000
ffffffff8117aa08 ffffffff815905c8 0000000000000080 10c38ca810c38c68
0000000000000008 00000001208d0094 10c38ca810c38c68 0000005558776460
ffffffffffffffa7 0000005558776428 0000000000000000 0000005558aace60
ffffffff814f8ba8 ffffffff81123f14 a800000092718000 a80000009271be30
0000005558776420 ffffffff8117aae8 0000000010108ce3 0000000000000249
...
Call Trace:
[<ffffffff811238c4>] do_ade+0x1f4/0x490
[<ffffffff81100880>] ret_from_exception+0x0/0x8
[<ffffffff81100590>] less_than_4units+0xc/0x5c
[<ffffffff8117aae8>] SyS_futex+0xe0/0x1c0
[<ffffffff81102bc4>] handle_sys64+0x44/0x60
We are doing a copy_from_user(), with a bad address passed in from
userspace. The access_ok() says it is fine, but when we drop into the
memcpy, we get the Address Error Exception because we exceeded SEGBITS.
Really we want to clamp things at the SEGBITS boundry.
David Daney
prev parent reply other threads:[~2010-10-13 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 17:53 [PATCH v2] MIPS: Make TASK_SIZE reflect proper size for both 32 and 64 bit processes David Daney
2010-10-13 21:46 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB628A2.5060705@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.