Re: [PATCH v2] module.bbclass: fix dependency on specific kernel

[Andreas Oberritter <obi@opendreambox.org>]

On 10/14/2010 12:30 AM, Chris Larson wrote:
> On Wed, Oct 13, 2010 at 3:09 PM, Andreas Oberritter <obi@opendreambox.org>wrote:
> 
>> * Previously, the kernel version did not show up in the
>>  generated control file (debian ipk).
>> * Use the same format as in kernel.bbclass.
>>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> ---
>>  classes/module.bbclass |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/classes/module.bbclass b/classes/module.bbclass
>> index 0e0018e..601a882 100644
>> --- a/classes/module.bbclass
>> +++ b/classes/module.bbclass
>> @@ -1,4 +1,4 @@
>> -RDEPENDS_${PN} += "kernel (${KERNEL_VERSION}) update-modules"
>> +RDEPENDS_${PN} += "kernel-${KERNEL_VERSION} update-modules"
>>  DEPENDS += "virtual/kernel"
>>
> 
> This looks just plain wrong to me.  kernel-<version> is bitbake build time
> syntax, kernel (<version>) is runtime syntax for dpkg/opkg.

Does this mean that kernel.bbclass is wrong, too? Because kernel.bbclass
calls do_split_packages with extra_depends='update-modules
kernel-${KERNEL_VERSION}', which translates to
RDEPENDS_kernel-module-foo = "update-modules kernel-${KERNEL_VERSION}".

Regards,
Andreas