From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>,
Christoph Hellwig <hch@lst.de>,
LKML <linux-kernel@vger.kernel.org>,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH net-next] net: allocate skbs on local node
Date: Thu, 14 Oct 2010 09:22:35 +0300 [thread overview]
Message-ID: <4CB6A1AB.4030800@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1010131539440.27839@chino.kir.corp.google.com>
On Wed, 13 Oct 2010, Christoph Lameter wrote:
>>> I was going to mention that as an idea, but I thought storing the metadata
>>> for certain debugging features might differ from the two allocators so
>>> substantially that it would be even more convoluted and difficult to
>>> maintain?
>>
>> We could have some callbacks to store allocator specific metadata?
On 10/14/10 1:41 AM, David Rientjes wrote:
> It depends on whether we could share the same base for both slab (unified
> allocator) and slub, which you snipped from your reply, that would make
> this cleaner.
Argh. Why would we want to introduce something that's effectively a new
allocator based on SLUB? If there's something controversial in the
current patch series, lets just keep it out of mainline. A "rewrite" is
the reason we're in this mess so lets not repeat the same mistake again!
Pekka
next prev parent reply other threads:[~2010-10-14 6:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 23:03 [PATCH net-next] bnx2x: dont use netdev_alloc_skb() Eric Dumazet
2010-10-11 23:22 ` Eric Dumazet
2010-10-12 5:03 ` Tom Herbert
2010-10-12 5:16 ` Eric Dumazet
2010-10-12 9:12 ` Vladislav Zolotarov
2010-10-14 17:39 ` David Miller
2010-10-14 18:17 ` Eilon Greenstein
2010-10-14 18:20 ` Eric Dumazet
2010-10-14 18:25 ` David Miller
2010-10-14 18:17 ` Tom Herbert
2010-10-12 5:05 ` [PATCH net-next] net: allocate skbs on local node Eric Dumazet
2010-10-12 5:35 ` Tom Herbert
2010-10-12 6:03 ` Andrew Morton
2010-10-12 6:58 ` Eric Dumazet
2010-10-12 7:24 ` Andrew Morton
2010-10-12 7:49 ` Eric Dumazet
2010-10-12 7:58 ` Andrew Morton
2010-10-12 11:08 ` Pekka Enberg
2010-10-12 12:50 ` Christoph Lameter
2010-10-12 19:43 ` David Rientjes
2010-10-13 6:17 ` Pekka Enberg
2010-10-13 6:31 ` David Rientjes
2010-10-13 6:36 ` Pekka Enberg
2010-10-13 16:00 ` Christoph Lameter
2010-10-13 20:48 ` David Rientjes
2010-10-13 21:43 ` Christoph Lameter
2010-10-13 22:41 ` David Rientjes
2010-10-14 6:22 ` Pekka Enberg [this message]
2010-10-14 7:23 ` David Rientjes
2010-10-15 14:23 ` Christoph Lameter
2010-10-14 15:31 ` Tom Herbert
2010-10-14 16:05 ` Eric Dumazet
2010-10-15 16:57 ` Christoph Lameter
2010-10-14 19:27 ` Andrew Morton
2010-10-14 19:59 ` Eric Dumazet
2010-10-16 18:54 ` David Miller
2010-10-12 16:07 ` [BUG net-next] bnx2x: all traffic comes to RX queue 0 Eric Dumazet
2010-10-12 16:20 ` Dmitry Kravkov
2010-10-12 18:11 ` Eric Dumazet
2010-10-12 18:18 ` Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB6A1AB.4030800@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.