From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jin Dongming Subject: [PATCH 01/11] kvm, x86: ignore SRAO only when MCG_SER_P is available Date: Thu, 14 Oct 2010 17:41:03 +0900 Message-ID: <4CB6C21F.8000303@np.css.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Dean Nelson , Marcelo Tosatti , Huang Ying , Hidetoshi Seto , "qemu-devel@nongnu.org" , Avi Kivity To: KVM list Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:40831 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754703Ab0JNIjn (ORCPT ); Thu, 14 Oct 2010 04:39:43 -0400 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9E8df4J028571 for (envelope-from jin.dongming@np.css.fujitsu.com); Thu, 14 Oct 2010 17:39:41 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 5383145DE4E for ; Thu, 14 Oct 2010 17:39:41 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 31B3045DE4D for ; Thu, 14 Oct 2010 17:39:41 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 17460E08001 for ; Thu, 14 Oct 2010 17:39:41 +0900 (JST) Received: from m002.s.css.fujitsu.com (m002.s.css.fujitsu.com [10.23.4.32]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id D106A1DB803B for ; Thu, 14 Oct 2010 17:39:37 +0900 (JST) Sender: kvm-owner@vger.kernel.org List-ID: And restruct this block to call kvm_mce_in_exception() only when it is required. Signed-off-by: Hidetoshi Seto Tested-by: Jin Dongming --- qemu-kvm.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index e78d850..6f62973 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1903,12 +1903,15 @@ static void kvm_do_inject_x86_mce(void *_data) struct kvm_x86_mce_data *data = _data; int r; - /* If there is an MCE excpetion being processed, ignore this SRAO MCE */ - r = kvm_mce_in_exception(data->env); - if (r == -1) { - fprintf(stderr, "Failed to get MCE status\n"); - } else if (r && !(data->mce->status & MCI_STATUS_AR)) { - return; + /* If there is an MCE exception being processed, ignore this SRAO MCE */ + if ((data->env->mcg_cap & MCG_SER_P) && + !(data->mce->status & MCI_STATUS_AR)) { + r = kvm_mce_in_exception(data->env); + if (r == -1) { + fprintf(stderr, "Failed to get MCE status\n"); + } else if (r) { + return; + } } r = kvm_set_mce(data->env, data->mce); if (r < 0) { -- 1.7.1.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59082 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6JLi-0004sF-Hp for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:39:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6JLh-0002B3-Fh for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:39:42 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:40828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6JLh-0002Ap-13 for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:39:41 -0400 Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9E8dc13028554 for (envelope-from jin.dongming@np.css.fujitsu.com); Thu, 14 Oct 2010 17:39:38 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 4DD1745DE4F for ; Thu, 14 Oct 2010 17:39:38 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 316E545DE4E for ; Thu, 14 Oct 2010 17:39:38 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 1A06F1DB8016 for ; Thu, 14 Oct 2010 17:39:38 +0900 (JST) Received: from m002.s.css.fujitsu.com (m002.s.css.fujitsu.com [10.23.4.32]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id D15FA1DB8014 for ; Thu, 14 Oct 2010 17:39:37 +0900 (JST) Message-ID: <4CB6C21F.8000303@np.css.fujitsu.com> Date: Thu, 14 Oct 2010 17:41:03 +0900 From: Jin Dongming MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 01/11] kvm, x86: ignore SRAO only when MCG_SER_P is available List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: KVM list Cc: Hidetoshi Seto , Dean Nelson , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity , Huang Ying And restruct this block to call kvm_mce_in_exception() only when it is required. Signed-off-by: Hidetoshi Seto Tested-by: Jin Dongming --- qemu-kvm.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index e78d850..6f62973 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1903,12 +1903,15 @@ static void kvm_do_inject_x86_mce(void *_data) struct kvm_x86_mce_data *data = _data; int r; - /* If there is an MCE excpetion being processed, ignore this SRAO MCE */ - r = kvm_mce_in_exception(data->env); - if (r == -1) { - fprintf(stderr, "Failed to get MCE status\n"); - } else if (r && !(data->mce->status & MCI_STATUS_AR)) { - return; + /* If there is an MCE exception being processed, ignore this SRAO MCE */ + if ((data->env->mcg_cap & MCG_SER_P) && + !(data->mce->status & MCI_STATUS_AR)) { + r = kvm_mce_in_exception(data->env); + if (r == -1) { + fprintf(stderr, "Failed to get MCE status\n"); + } else if (r) { + return; + } } r = kvm_set_mce(data->env, data->mce); if (r < 0) { -- 1.7.1.1