From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jin Dongming Subject: [PATCH 02/11] kvm, x86: introduce kvm_do_set_mce Date: Thu, 14 Oct 2010 17:42:52 +0900 Message-ID: <4CB6C28C.4050902@np.css.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Dean Nelson , Marcelo Tosatti , Avi Kivity , Huang Ying , Hidetoshi Seto , "qemu-devel@nongnu.org" To: KVM list Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:43748 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754979Ab0JNIl2 (ORCPT ); Thu, 14 Oct 2010 04:41:28 -0400 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9E8fRhK019144 for (envelope-from jin.dongming@np.css.fujitsu.com); Thu, 14 Oct 2010 17:41:27 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 3D1D245DE4E for ; Thu, 14 Oct 2010 17:41:27 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1BA4345DE4D for ; Thu, 14 Oct 2010 17:41:27 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 034F5E08002 for ; Thu, 14 Oct 2010 17:41:27 +0900 (JST) Received: from m001.s.css.fujitsu.com (m001.s.css.fujitsu.com [10.23.4.39]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id B8F33E08001 for ; Thu, 14 Oct 2010 17:41:26 +0900 (JST) Sender: kvm-owner@vger.kernel.org List-ID: Share the same error handling. Signed-off-by: Hidetoshi Seto Tested-by: Jin Dongming --- qemu-kvm.c | 31 +++++++++++++++++++------------ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 6f62973..1338e99 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1130,6 +1130,22 @@ static void sigbus_reraise(void) abort(); } +#if defined(KVM_CAP_MCE) && defined(TARGET_I386) +static void kvm_do_set_mce(CPUState *env, struct kvm_x86_mce *mce, + int abort_on_error) +{ + int r; + + r = kvm_set_mce(env, mce); + if (r < 0) { + perror("kvm_set_mce FAILED"); + if (abort_on_error) { + abort(); + } + } +} +#endif + static void sigbus_handler(int n, struct qemu_signalfd_siginfo *siginfo, void *ctx) { @@ -1365,11 +1381,7 @@ static void kvm_on_sigbus(CPUState *env, siginfo_t *siginfo) } } mce.addr = paddr; - r = kvm_set_mce(env, &mce); - if (r < 0) { - fprintf(stderr, "kvm_set_mce: %s\n", strerror(errno)); - abort(); - } + kvm_do_set_mce(env, &mce, 1); } else #endif { @@ -1913,13 +1925,8 @@ static void kvm_do_inject_x86_mce(void *_data) return; } } - r = kvm_set_mce(data->env, data->mce); - if (r < 0) { - perror("kvm_set_mce FAILED"); - if (data->abort_on_error) { - abort(); - } - } + + kvm_do_set_mce(data->env, data->mce, data->abort_on_error); } #endif -- 1.7.1.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59774 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6JNS-0005gH-7K for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:41:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6JNR-0002Py-5K for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:41:30 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:40935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6JNQ-0002Pu-MS for qemu-devel@nongnu.org; Thu, 14 Oct 2010 04:41:29 -0400 Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9E8fRDU029488 for (envelope-from jin.dongming@np.css.fujitsu.com); Thu, 14 Oct 2010 17:41:27 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 3671C45DE4E for ; Thu, 14 Oct 2010 17:41:27 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 1428345DE4D for ; Thu, 14 Oct 2010 17:41:27 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id F35CA1DB8045 for ; Thu, 14 Oct 2010 17:41:26 +0900 (JST) Received: from m001.s.css.fujitsu.com (m001.s.css.fujitsu.com [10.23.4.39]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id B74E61DB803C for ; Thu, 14 Oct 2010 17:41:26 +0900 (JST) Message-ID: <4CB6C28C.4050902@np.css.fujitsu.com> Date: Thu, 14 Oct 2010 17:42:52 +0900 From: Jin Dongming MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 02/11] kvm, x86: introduce kvm_do_set_mce List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: KVM list Cc: Hidetoshi Seto , Dean Nelson , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity , Huang Ying Share the same error handling. Signed-off-by: Hidetoshi Seto Tested-by: Jin Dongming --- qemu-kvm.c | 31 +++++++++++++++++++------------ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 6f62973..1338e99 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1130,6 +1130,22 @@ static void sigbus_reraise(void) abort(); } +#if defined(KVM_CAP_MCE) && defined(TARGET_I386) +static void kvm_do_set_mce(CPUState *env, struct kvm_x86_mce *mce, + int abort_on_error) +{ + int r; + + r = kvm_set_mce(env, mce); + if (r < 0) { + perror("kvm_set_mce FAILED"); + if (abort_on_error) { + abort(); + } + } +} +#endif + static void sigbus_handler(int n, struct qemu_signalfd_siginfo *siginfo, void *ctx) { @@ -1365,11 +1381,7 @@ static void kvm_on_sigbus(CPUState *env, siginfo_t *siginfo) } } mce.addr = paddr; - r = kvm_set_mce(env, &mce); - if (r < 0) { - fprintf(stderr, "kvm_set_mce: %s\n", strerror(errno)); - abort(); - } + kvm_do_set_mce(env, &mce, 1); } else #endif { @@ -1913,13 +1925,8 @@ static void kvm_do_inject_x86_mce(void *_data) return; } } - r = kvm_set_mce(data->env, data->mce); - if (r < 0) { - perror("kvm_set_mce FAILED"); - if (data->abort_on_error) { - abort(); - } - } + + kvm_do_set_mce(data->env, data->mce, data->abort_on_error); } #endif -- 1.7.1.1