Re: [PATCH] Support or LME2510(C) DM04/QQBOX USB DVB-S BOXES.

[Mauro Carvalho Chehab <maurochehab@gmail.com>]

Em 13-10-2010 16:10, Antti Palosaari escreveu:
> On 09/02/2010 11:29 PM, tvbox wrote:
>> DM04/QQBOX DVB-S USB BOX with LME2510C+SHARP:BS2F7HZ7395 or LME2510+LGTDQT-P001F tuner.
> 
>> +config DVB_USB_LME2510
>> +    tristate "LME DM04/QQBOX DVB-S USB2.0 support"
>> +    depends on DVB_USB
>> +    select DVB_TDA10086 if !DVB_FE_CUSTOMISE
>> +    select DVB_TDA826X if !DVB_FE_CUSTOMISE
>> +    select DVB_STV0288 if !DVB_FE_CUSTOMISE
>> +    select DVB_IX2505V if !DVB_FE_CUSTOMISE
>> +    select IR_CORE
>> +    help
>> +      Say Y here to support the LME DM04/QQBOX DVB-S USB2.0 .
> 
> Just for curious, is IR_CORE and DVB_USB both needed? DVB_USB also depends on IR_CORE ? This was only DVB-USB driver which does that.

First of all, you shouldn't never use select with IR_CORE. This won't work for menu items. 
It should use only depends on.

With respect to DVB_USB, as we have:

config DVB_USB
	tristate "Support for various USB DVB devices"
	depends on DVB_CORE && USB && I2C && IR_CORE


The IR_CORE dependency is already there, so, DVB_USB_LME2510 shouldn't need do use dependency
related to IR.

Cheers,
Mauro